Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken storage layout issue as a result of #313 #330

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix broken storage layout issue as a result of #313 #330

merged 1 commit into from
Nov 9, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 6, 2023 •
edited
Loading

Storage layout was broken in #313. This removes an interface inheritance that broke it before

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 6, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@oveddan oveddan changed the title Revert #313 include errors in abi. (caused storage layout bugs) Fix broken storage layout issue Nov 6, 2023
@oveddan oveddan changed the base branch from main to remove-factory-impl-check November 6, 2023 20:00
@oveddan oveddan mentioned this pull request Nov 6, 2023
Merged
@iainnash
Copy link
Collaborator

iainnash commented Nov 6, 2023 •
edited
Loading

is this a git revert?

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 6, 2023

is this a git revert?

it was originally, but this just fixes that issue. if preferred, we can do a separate git rollback

@oveddan oveddan mentioned this pull request Nov 6, 2023
Merged
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 6, 2023

is this a git revert?

it was originally, but this just fixes that issue. if preferred, we can do a separate git rollback

@iainnash #332 does a full revert. If desired, we can go with that, then do this diff on top of that to fix the issue

@oveddan oveddan changed the title Fix broken storage layout issue Fix broken storage layout issue as a result of #313 Nov 6, 2023
This was referenced Nov 6, 2023
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Merged
@oveddan oveddan changed the base branch from remove-factory-impl-check to main November 8, 2023 23:18
@oveddan oveddan changed the base branch from main to remove-factory-impl-check November 8, 2023 23:19
@oveddan oveddan changed the base branch from remove-factory-impl-check to main November 8, 2023 23:28
@oveddan oveddan mentioned this pull request Nov 9, 2023
Closed
@oveddan oveddan merged commit 366ac20 into main Nov 9, 2023
5 checks passed
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 9, 2023

Merge activity

iainnash pushed a commit that referenced this pull request Jan 11, 2024
@oveddan
Fix broken storage layout issue as a result of #313 (#330)
bd5854c 
Storage layout was broken in #313.  This removes an interface inheritance that broke it before
@iainnash iainnash deleted the revert-abi-inclusion branch January 11, 2024 15:37
oveddan pushed a commit that referenced this pull request May 10, 2024
@IsabellaSmallcombe
Add Mints Manager and Mints Addresses to Subgraph (#330)
5888fd2 
* feat: add new zora sepolia addresses

* feat: add zora mainnet addresses

* feat: add mintsManagerImpl to index MintComments

* fix: update changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainnash iainnash iainnash approved these changes

@IsabellaSmallcombe IsabellaSmallcombe Awaiting requested review from IsabellaSmallcombe

@kulkarohan kulkarohan Awaiting requested review from kulkarohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oveddan @iainnash