Premint - get supported premint signature version #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
Merged
Merged
oveddan
force-pushed
the
get-supported-premint-version
branch
from
1d60d6e
to
9a2a7de
Compare
iainnash
reviewed
Oct 26, 2023
| /// @return The version of the premint signature that the contract supports. If it doesn't support premint | ||
| /// returns 0 | ||
| function supportedPremintSignatureVersion(address contractAddress) external view returns (string memory) { | ||
| IZoraCreator1155 creatorContract = IZoraCreator1155(contractAddress); |
There was a problem hiding this comment.
should version be a string or an integer?
There was a problem hiding this comment.
hrrrm great q. when you sign the message, the version according to eip-712 is a string. so maybe it makes sense for this to actually return an array saying supportedSignatureVersions with an array of the versions supported?
or we store internally as integers and convert to string in the eip-712 domain, and this returns a an integer which acts as a max version.
There was a problem hiding this comment.
String is fine for alignment for EIP-712. Another option would be to stringify an integer to come up.
iainnash
previously approved these changes
Oct 26, 2023
kulkarohan
reviewed
Oct 26, 2023
| } | ||
|
|
||
| // try get token id for uid 0 - if call fails, we know this didn't support premint | ||
| try ERC1155DelegationStorageV1(contractAddress).delegatedTokenId(uint32(0)) returns (uint256) { |
There was a problem hiding this comment.
are we somehow ensuring that the first premint executed on a contract is uid 0?
There was a problem hiding this comment.
it doesn't really matter here - this is really just checking if that function exists on the contract. even if the uid is not 0, this will return 0. It will revert if the function doesn't exist on the contract
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
4d8f817
to
b13aecc
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
9a2a7de
to
03dd79a
Compare
iainnash
reviewed
Oct 27, 2023
| try ERC1155DelegationStorageV1(contractAddress).delegatedTokenId(uint32(0)) returns (uint256) { | ||
| return "1"; | ||
| } catch { | ||
| return "0"; |
There was a problem hiding this comment.
should we return empty string here?
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
b13aecc
to
987a31f
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
03dd79a
to
581167d
Compare
This was referenced Oct 30, 2023
Merged
oveddan
force-pushed
the
allow-minting-on-v1-contracts
branch
from
987a31f
to
13bec21
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
b9d5595
to
9602e4e
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
73aff5e
to
a0c248c
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
9602e4e
to
f69802c
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
a0c248c
to
6244493
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
f69802c
to
1164900
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
6244493
to
9a47b0e
Compare
Closed
oveddan
force-pushed
the
default-msg-sender
branch
from
1164900
to
5d465d3
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
9a47b0e
to
b5f3019
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
5d465d3
to
388f2d7
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
b5f3019
to
24e5de5
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
388f2d7
to
26a3e3e
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
24e5de5
to
9bc75d9
Compare
Merge activity
|
oveddan
force-pushed
the
default-msg-sender
branch
from
26a3e3e
to
db0f740
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
9bc75d9
to
48830c3
Compare
oveddan
force-pushed
the
default-msg-sender
branch
from
db0f740
to
bf2eb9d
Compare
This reverts commit d57f2990d9046c7e9f7d29ec2105902b3bb59830.
This was referenced Nov 17, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
Added method `IZoraCreator1155PremintExecutor.supportedPremintSignatureVersion(contractAddress)` that tells what version of the premint signature the contract supports, and added corresponding method `ZoraCreator1155Impl.supportedPremintSignatureVersion()` to fetch supported version. If premint not supported, returns 0.
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Added method `IZoraCreator1155PremintExecutor.supportedPremintSignatureVersion(contractAddress)` that tells what version of the premint signature the contract supports, and added corresponding method `ZoraCreator1155Impl.supportedPremintSignatureVersion()` to fetch supported version. If premint not supported, returns 0.
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Added method `IZoraCreator1155PremintExecutor.supportedPremintSignatureVersion(contractAddress)` that tells what version of the premint signature the contract supports, and added corresponding method `ZoraCreator1155Impl.supportedPremintSignatureVersion()` to fetch supported version. If premint not supported, returns 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method
IZoraCreator1155PremintExecutor.supportedPremintSignatureVersion(contractAddress)that tells what version of the premint signature the contract supports, and added corresponding methodZoraCreator1155Impl.supportedPremintSignatureVersion()to fetch supported version. If premint not supported, returns 0.