Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prettier formatting in all packages, and formatted code #360

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 14, 2023

fixed prettier checks in all projects.
formatted incorrectly formatted code

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 14, 2023

iainnash
iainnash previously approved these changes Nov 14, 2023
@oveddan oveddan changed the base branch from shared-tsconfig to main November 15, 2023 00:45
@oveddan oveddan dismissed stale reviews from IsabellaSmallcombe and iainnash November 15, 2023 00:45

The base branch was changed.

@oveddan oveddan merged commit e6cb2a8 into main Nov 15, 2023
9 checks passed
iainnash pushed a commit that referenced this pull request Jan 5, 2024
fixed prettier checks in all projects.
formatted incorrectly formatted code
iainnash pushed a commit that referenced this pull request Jan 11, 2024
fixed prettier checks in all projects.
formatted incorrectly formatted code
iainnash pushed a commit that referenced this pull request Jan 11, 2024
fixed prettier checks in all projects.
formatted incorrectly formatted code
@iainnash iainnash deleted the formatted-prettier branch January 11, 2024 15:36
oveddan added a commit that referenced this pull request May 10, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description

Make sure to save/load erc20 minter from the deployment config, so that when we run `copy-deployed-contracts` its not removed

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## Does this change the ABI/API?

- [ ] This changes the ABI/API

<!-- If so, please describe how and what potential impact this may have -->

## What tests did you add/modify to account for these changes

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New module / feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] i added a changeset to account for this change

## Reviewer Checklist:

- [ ] My review includes a symposis of the changes and potential issues
- [ ] The code style is enforced
- [ ] There are no risky / concerning changes / additions to the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants