Refactorize visualization Capacity and Infrastructure #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-brousse
commented
Jun 19, 2024
•
nicolas-brousse
commented
- Implement form
- Implement turbo frame or stream
- Re-Implement LeaderLine
- Cleanup code view
- Try to optimize SQL queries / add cache
- Remove old code
- Move some element in components?
- Tests
B-Rass
force-pushed
the
upgrade-to-bootstrap-4
branch
2 times, most recently
from
f511273
to
8925664
Compare
nicolas-brousse
force-pushed
the
refactorize-visualization-capacity-and-infrastructure
branch
2 times, most recently
from
5d22712
to
fadf037
Compare
nicolas-brousse
force-pushed
the
refactorize-visualization-capacity-and-infrastructure
branch
from
3c07270
to
80b33f8
Compare
nicolas-brousse
force-pushed
the
refactorize-visualization-capacity-and-infrastructure
branch
from
80b33f8
to
72f0be4
Compare
B-Rass
force-pushed
the
upgrade-to-bootstrap-4
branch
from
1b227b6
to
dbce81e
Compare
…actorize-visualization-capacity-and-infrastructure
nicolas-brousse
force-pushed
the
refactorize-visualization-capacity-and-infrastructure
branch
from
bf8e7a5
to
3b9b1f8
Compare
nicolas-brousse
force-pushed
the
refactorize-visualization-capacity-and-infrastructure
branch
from
3b9b1f8
to
33eb8eb
Compare
B-Rass
requested changes
Aug 7, 2024
| .where.not(network_types: []) | ||
| # .includes(:cards, :ports => [:connection => [:port, :cable =>[:connections => [:port => :card]]]]). | ||
| @concentrateurs_ids = [383, 384, 1043, 1044] | ||
| @concentrateurs = Server.where(id: @concentrateurs_ids).includes(:ports => :connection, :cards => [:ports => :connection]) |
Co-authored-by: B-Rass <B-Rass@users.noreply.github.com>
B-Rass
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Remove the not translated string here ("Appliquer", "Loading..")
B-Rass
approved these changes
Aug 7, 2024
B-Rass
deleted the
refactorize-visualization-capacity-and-infrastructure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.