forked from nanego/my-dcim
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorize visualization Capacity and Infrastructure #5
Merged
B-Rass
merged 201 commits into
upgrade-to-bootstrap-4
from
refactorize-visualization-capacity-and-infrastructure
Aug 7, 2024
Merged
Changes from 198 commits
Commits
Show all changes
201 commits
Select commit
Hold shift + click to select a range
59ac6dd
wip
nicolas-brousse d178a4d
wip
nicolas-brousse 320e007
wip
nicolas-brousse 41b86c3
cleanup
nicolas-brousse 064058f
wip
B-Rass 4f69f7a
fix js
nicolas-brousse 641429a
wip
nicolas-brousse 4042978
wip js
nicolas-brousse 119b7f8
cleanup
nicolas-brousse 3c528d8
Update layout/navigation
B-Rass 4c95be3
Add breadcrumb
B-Rass ae7ff2d
Build Sidebar
B-Rass 63aa246
Fix responsive main menu
B-Rass 0396792
Update Logins pages
B-Rass 9236087
Update alerts
B-Rass a66ef2e
Update views after merge Connection + update icons
B-Rass 680ec6e
Clean inventories indexes
B-Rass fc08a57
Update kaminari views
B-Rass 58f06e5
Update Changelog#index + debug menu on mobile
B-Rass 231683f
Fixing home
B-Rass 01e4d7e
Clean sidebar
B-Rass 416938a
Fixing new list Connections and Cables
B-Rass 4e157ec
Replace sassc-rails by dartsass-sprockets
nicolas-brousse 1a1bb1a
Update CardComponent
B-Rass 3e8fdd7
Update form_errors_component
B-Rass 9e34551
Update FilterComponent
B-Rass ca493ed
Update Rooms views: capacity, infrastructure, show, overview(+filtered)
B-Rass a6ffd8a
Fixing Rooms#overview
B-Rass 6149fb7
improving general layout
B-Rass 7420e47
Improving general style (background colors)
B-Rass 904b981
Improve Dark mode for Capacity and overviews
B-Rass 3492b75
Prevent Inventories menu to show Room as active on Visualization views
B-Rass 3b1396f
Improve Home page for dark mode
B-Rass 6f22d62
Debug devices_dropdown + improve dark mode
B-Rass 0c80277
Upgrade removed "panel" class to "card" one instead
B-Rass d54a886
Improve filtered_overview layout + dark-mode rework (for overview also)
B-Rass 51c3436
Remove bootstrap-generator file
B-Rass 116000d
Debug related class + improve highlighted style on bays/overview (l/d m)
B-Rass 6876e1b
js fixes
nicolas-brousse 1f310a6
fix js
nicolas-brousse 0c43f31
cleanup
nicolas-brousse f00aa34
cleanup
nicolas-brousse f5a0f6a
Remove deleted class "well" + clean code
B-Rass e0a706d
Update registration#edit page
B-Rass 7528500
Clean + improve border on sidebar and header
B-Rass 85c8757
Update about page
B-Rass d66f48d
Update Users#new page
B-Rass 2f07986
Improve bg colors
B-Rass 8e42b32
Fix active state on rooms_menu in visualization views
B-Rass 9505bb5
Clean code
B-Rass 9def61b
Update infrastructure view to make it works on Dark mode + cleans
B-Rass 54232fe
Update User#show view
B-Rass b8cd05c
Update site forms
B-Rass 13d28f2
Clean
B-Rass 069628a
Update Site#show
B-Rass 2ef9f47
fix bootstrap tooltips
nicolas-brousse 531905b
fix jquery and jquery-ui and some js
nicolas-brousse a3a2712
Update Site#index page title
B-Rass 69b8091
Update Room#new & Room#edit
B-Rass 929a733
Update Room#index
B-Rass ae2b64b
Update Islet#index
B-Rass c444597
Clean code
B-Rass 5bae22e
Update Islet#forms (new & edit)
B-Rass 986059a
Update Bay#index
B-Rass 756f366
Clean code
B-Rass d73d71c
Update Bay#forms (new/edit)
B-Rass f586073
Site, Room, Islet: improve responsive of headers + accessibility
B-Rass e4c8850
Debug CaptionComponent
B-Rass de14306
Update Bay#show
B-Rass 5434839
Clean code
B-Rass 559069e
Update Frame#index
B-Rass 36c1897
Update Frame forms (edit/new)
B-Rass bcd2246
Update Server#index
B-Rass f20ce9b
Update Server#import_csv
B-Rass 1f9d8ba
Fixing tests
B-Rass 4785ad7
Adding management of theme (user settings + js)
B-Rass bede05e
Raw fix of infrastructure to make LeaderLine works with scroll
B-Rass e33164f
Add AnimEvent for LeaderLine scroll
B-Rass 63cfc3e
Server#form (new & edit) except nested_forms
B-Rass 80c5ef7
refactor: update Server documents form to use stimulus nested form co…
nicolas-brousse e5eba2b
refactor: update Modele enclosures form to use stimulus nested form c…
nicolas-brousse d250576
refactor: update Server cards form to use stimulus nested form contro…
nicolas-brousse acc343d
cleanup: create custom nested form controller form nested nested forms
nicolas-brousse 6b5e878
style: code cleanup
nicolas-brousse d7e4bec
Server: update show + forms (edit, new, duplicate)
B-Rass 7914883
Update Modele#index
B-Rass 0937c24
Update Modele#forms (new + edit), except nested_forms
B-Rass da6e7b7
Update Modele#show
B-Rass 969e916
Update Category views (index, show, forms) + clean other show updated
B-Rass 0060f2d
Update Architecture views (index, show, forms)
B-Rass 33b2864
Update Manufacturer views (index, show, forms) + clean other show upd…
B-Rass 9c4c01c
Update Stack views (index, show, forms)
B-Rass efa8754
Update CardType views (index, show, forms)
B-Rass 203f66f
Update PortType views (index, show, forms)
B-Rass 3243cf4
Update DiskType views (index, show, forms)
B-Rass 3420b6a
Update MemoryType views (index, show, forms)
B-Rass 09e8bc2
Update Domaine views (index, show, forms)
B-Rass 2c511dd
Update Gestion views (index, show, forms)
B-Rass 7ae38ce
Update Cluster views (index, show, forms)
B-Rass 04a49b7
Clean shows: add missing closing tag for dd
B-Rass b46a77e
Update Color views (index, show, edit)
B-Rass 60e1d79
Update Maintainer views (index, show, forms)
B-Rass fb5ad23
Update ContractType views (index, show, forms)
B-Rass 789147d
Clean code
B-Rass bd75725
Clean Flash message CSS for devise layout
B-Rass a70bf58
refactor: update Modele enclosures composants form to use stimulus ne…
nicolas-brousse bd5389b
style: code cleanup
nicolas-brousse bea0fc5
Fix Sortable on modeles form enclosures slot
nicolas-brousse 1be5f31
Update Connection#edit form
B-Rass e2e481b
wip: fixes js on capacity and infrastructure pages
nicolas-brousse 11bdcc7
Update Modele#enclosure nested forms
B-Rass 1d74aff
fix: add missing wrapper clss for Modele enclosures composants nested…
nicolas-brousse 99f88e3
Clean dark mode for TomSelect options
B-Rass 177d921
Css clean on message component (increase z-index)
B-Rass badb5a5
Clean Server#form and Modele#form: use locales
B-Rass 6a399d3
Clean Sidebar + add AirConditionner
B-Rass 79ba132
Update AirConditionner views (index, show, new, edit, form)
B-Rass 7c6a756
Clean enclosure forms on Modele
B-Rass 139d5ab
Improve Accessibility on Server#form (document_fields)
B-Rass 8814daa
Remove span.caret
B-Rass 756a105
Remove unused page-header class
B-Rass a57bd4c
Rebase from master + manage updates to AirConditionner views
B-Rass 04cc45a
Update Changelog table + Update diffy css for dark mode
B-Rass 8aa6bc1
Update ChangelogEntry#show
B-Rass 4d18d01
Add missing view Islet#show + move IsletController test to RSpec
B-Rass 8f54e72
Update Move pages (index, new, edit, frame)
B-Rass 11dd8c2
Update Scaffold views
B-Rass 1bfa53d
Improve bay and frame shows
B-Rass 862f793
Fix scroll for LeaderLines on bay views
B-Rass 43e5a2c
Improve PDU responsive and dark mode
B-Rass a2f36d6
Improve Frames#show and Bays#show responsiveness
B-Rass a3d7c02
Improve border-style for port (draw_component) for dark mode
B-Rass 97d013b
Improve even/odd lines on bays for dark mode
B-Rass 1404a01
No text-decoration on #back_server_ tags child links
B-Rass 1f5bb74
Improve Server#show responsiveness
B-Rass 2096213
Update Frames#network view
B-Rass fca4050
Update Room#show header (overview)
B-Rass 1ad1735
Comment failing test
B-Rass 9d1c0cc
Fixing rspec test: wrong indentation
B-Rass b08d9ac
Rubocop cleans
B-Rass a1e7e16
Room#show: fixing js update of breadcrumbs
B-Rass b0f527a
Room#show: add missing background color to overviewed_frame
B-Rass d0810ec
Clean breadcrumbs
B-Rass 945d113
Room#show: Add expand icon version of collapse/expand button
B-Rass 4380a83
Decrease general website font size
B-Rass 099805b
Fixing css on action_button
B-Rass 0f2cb67
Fixing Move#form: initial_bay div wasn't scrolling
B-Rass 6167ed5
Fixing drawing server responsiveness
B-Rass 443559d
Fix: use right plural for models xxxType
B-Rass 0c1be10
Fixing AirConditioner test
B-Rass 1a56530
Use fieldset on FilterComponent
B-Rass 799a3f8
Fix wrong rebase
B-Rass 6d9da0b
Improve Clim CSS
B-Rass 2a8f1cf
Harmonize flex-column flex-lg-row system
B-Rass 262fa35
Use of container-fluid to harmonize views
B-Rass b30dcd7
Update all edit buttons to be info type and not primary
B-Rass dbf22c0
Fix wrong rebase on Connection#index
B-Rass 01674cc
Remove clearfix
B-Rass 393ba82
Improve CSS: removing text-decoration on airconditioner
B-Rass e1a0e1c
Add use of CardComponent when possible
B-Rass 6a34846
Update Move#moved_connection_form
B-Rass 8076f3f
Update Move#frame page
B-Rass 21248ba
Update Devise#passwords#edit + clean passwords#new
B-Rass 7e148a6
Fix wrong route for unsuspended action on Users#index
B-Rass 2096e43
Fix and Clean ChangelogEntries views
B-Rass bdcb2b2
Clean Move views
B-Rass d04ba1e
Fix and clean ServerGrid view
B-Rass eb0059b
Clean frames#show_frame
B-Rass 7c66cdc
Fix and clean Site, Room and Islets views
B-Rass c2a2fd8
Check on inventories views (clean + fix)
B-Rass e555a99
Clean FilterComponent implementation in index views
B-Rass 929775e
Fix and clean vizual. views (servers component alignment + bg colors)
B-Rass ea686d0
CSS Clean on air_conditioner after rebase
B-Rass 1c12f48
draw_server_compact: fixing server_name too long CSS issue
B-Rass c0ae185
wip
nicolas-brousse ff49c11
wip
nicolas-brousse 574f238
wip
nicolas-brousse 79fe0a4
wip
nicolas-brousse e468eed
cleanups
nicolas-brousse e0876f3
cleanups
nicolas-brousse 1321285
add leader lines
nicolas-brousse e2f1cad
cleanups
nicolas-brousse 79b08ae
cleanups
nicolas-brousse b0e7e11
cleanups
nicolas-brousse 72f0be4
fix tests
nicolas-brousse 1f44fc8
add tests
nicolas-brousse ae3a8cb
fix tests
nicolas-brousse 84a0796
refactor: update visualization, apply default value on filters
nicolas-brousse 5e3ce7e
fix: make room visualization page tab works
nicolas-brousse 51f3680
fix: make room visualization page tab works
nicolas-brousse d9b87f1
fix: fix AirConditioner show page
nicolas-brousse c85c3f2
refactor: auto-submit visualization forms on changes
nicolas-brousse 40ad9be
Improve Stacks selection design
B-Rass 030dd5c
Fix Room#show islet tab switch
B-Rass e84d6e4
Merge remote-tracking branch 'origin/upgrade-to-bootstrap-4' into ref…
nicolas-brousse c9520c5
refactor
nicolas-brousse 33eb8eb
code clenaup
nicolas-brousse e4a651c
Update app/helpers/servers_helper.rb
nicolas-brousse c33b977
Re-add air_conditionner#show route
B-Rass 05d1ebd
cleanup
nicolas-brousse 8bf3c9b
cleanup
nicolas-brousse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
app/controllers/visualization/infrastructures_controller.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# frozen_string_literal: true | ||
|
||
module Visualization | ||
class InfrastructuresController < ApplicationController | ||
def show | ||
@filter = Filter.new(params, %i[network_type islet_id]) | ||
|
||
unless @filter.filled? | ||
islet_id = Islet.sorted.not_empty.has_name.distinct.first.id | ||
|
||
redirect_to islet_id:, network_type: :gbe | ||
end | ||
|
||
load_data! if turbo_frame_request? | ||
end | ||
|
||
private | ||
|
||
def load_data! | ||
@islet = Islet.find(@filter.islet_id) | ||
@room = @islet.room | ||
|
||
@servers = Server.includes(:frame, :stack, :ports, :cards => [:ports]) | ||
.where.not(network_types: []) | ||
# .includes(:cards, :ports => [:connection => [:port, :cable =>[:connections => [:port => :card]]]]). | ||
@concentrateurs_ids = [383, 384, 1043, 1044] | ||
@concentrateurs = Server.where(id: @concentrateurs_ids).includes(:ports => :connection, :cards => [:ports => :connection]) | ||
@switchs_lan_ids = @concentrateurs_ids | @servers.pluck(:id) # Switch LAN | ||
# TODO: Remove hard-coded values | ||
@hubs = {} | ||
|
||
unless Rails.env.test? | ||
@hubs = { "gbe" => { 4 => Server.find(383), 3 => Server.find(384) }, "10gbe" => { 4 => Server.find(1043), 3 => Server.find(1044) } } # Concentrateurs per room | ||
end | ||
|
||
@connections = {} | ||
@stacks = @servers.map(&:stack).uniq.compact | ||
@servers.each do |server| | ||
@connections[server.id] = server.directly_connected_servers_ids_with_color.reject { |conn| @switchs_lan_ids.exclude?(conn[:server_id]) } | ||
end | ||
@concentrateurs.each do |hub| | ||
@connections[hub.id] = hub.connected_servers_ids_through_twin_cards_with_color.reject { |conn| @switchs_lan_ids.exclude?(conn[:server_id]) } | ||
end | ||
|
||
# TODO: remove when hard-coded system will be removed | ||
@network_types = Modele::Network::TYPES.excluding("fiber") | ||
@network = @filter.network_type # TODO: take from params and raise error if not good | ||
|
||
return unless @room.id == 4 || @room.id == 3 | ||
|
||
@hub = @hubs[@network][@room.id] | ||
@second_room = Room.find(@room.id == 4 ? 3 : 4) | ||
@second_hub = @hubs[@network][@second_room.id] | ||
end | ||
end | ||
end |
27 changes: 27 additions & 0 deletions
27
app/controllers/visualization/network_capacities_controller.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# frozen_string_literal: true | ||
|
||
module Visualization | ||
class NetworkCapacitiesController < ApplicationController | ||
def show | ||
@filter = Filter.new(params, %i[network_type islet_id]) | ||
@filter_filled = @filter.filled? | ||
|
||
unless @filter.filled? | ||
islet_id = Islet.sorted.not_empty.has_name.distinct.first.id | ||
|
||
redirect_to islet_id:, network_type: :gbe | ||
end | ||
|
||
load_data! if turbo_frame_request? | ||
end | ||
|
||
private | ||
|
||
def load_data! | ||
@islet = Islet.find(@filter.islet_id) | ||
@room = @islet.room | ||
@network = @filter.network_type # TODO: take from params and raise error if not good | ||
@bays = @islet.bays.sorted | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# frozen_string_literal: true | ||
|
||
class IsletDecorator < ApplicationDecorator | ||
class << self | ||
def grouped_by_sites_options_for_select | ||
Islet.includes(:site, room: :islets).sorted.not_empty.has_name.distinct.group_by(&:site).to_h do |site, islets| | ||
islets = islets.map do |i| | ||
name = i.room.islets.size > 1 ? "#{i.room.name} Ilot #{i.name}" : i.room.name | ||
[name, i.id] | ||
end | ||
|
||
[site.name, islets] | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to remove those
=>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could