Fix two errors that stop the branch installing on phpBB 4 - #460
Open
ECYaz wants to merge 2 commits into
Open
Conversation
phpBB 4 rejects a length on MTEXT_UNI, so the migration throws in update_schema() before any table is created and enabling the extension fails.
Symfony Console 7 declares Command::execute() as returning int. phpBB builds every tagged command on each phpbbcli run, so without the return type every CLI call fatals once the extension is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things stop oberon installing on current master.
The migration declares two columns as MTEXT_UNI:255, but phpBB 4 rejects a length on that type, so enabling the extension throws before any table is created.
Both console commands declare execute() without the : int return type Symfony Console 7 requires, so once enabled every phpbbcli run fatals too.
Tested on a phpBB 4 dev board: with both applied the extension enables and the index renders.