Skip to content

Fix two errors that stop the branch installing on phpBB 4 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ECYaz wants to merge 2 commits into
base: oberon
Choose a base branch
from
+4 −4
Open

Fix two errors that stop the branch installing on phpBB 4 #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
694a0e1
Drop the length suffix on the MTEXT_UNI columns
ECYaz Aug 26, 2026
bc83d98
Add the int return type to the console command execute() methods
ECYaz Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/ai_validation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ protected function configure()
);
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$queue_id = (int) $input->getArgument('queue_id');
$output->writeln('<info>[execute] STARTING AI VALIDATION (v2)</info>');
Expand Down
2 changes: 1 addition & 1 deletion console/queue_manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected function configure()
->setHelp('Manage the Customisation DB queue');
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$output->writeln('<info>Begin queue manager...</info>');
$this->process($input, $output);
Expand Down
4 changes: 2 additions & 2 deletions migrations/oberon_migration_400.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function update_schema()
'contribution_id' => ['UINT', null, 'auto_increment'],
'contribution_status' => ['TINT', 0],
'contribution_name' => ['VCHAR_UNI:255', ''],
'contribution_description' => ['MTEXT_UNI:255', ''],
'contribution_description' => ['MTEXT_UNI', ''],
'contribution_type' => ['TINT', 0],
'contribution_demo_link' => ['VCHAR_UNI:255', ''],
'contribution_validation_topic_id' => ['UINT', 0],
Expand All @@ -78,7 +78,7 @@ public function update_schema()
'revision_name' => ['VCHAR_UNI:255', ''],
'revision_version' => ['VCHAR_UNI:255', ''],
'revision_phpbb_version' => ['VCHAR_UNI:255', ''],
'revision_description' => ['MTEXT_UNI:255', ''],
'revision_description' => ['MTEXT_UNI', ''],
'revision_attachment' => ['VCHAR_UNI:255', ''],
'revision_screenshots' => ['VCHAR_UNI:255', ''],
'user_id' => ['UINT', 0],
Expand Down