Environment Lock #693
Open
Environment Lock #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevoodoo
changed the title
illusional
requested changes
Apr 17, 2024
There was a problem hiding this comment.
For this one, and the images repo, we'll need to come up with some way that people can run this workflow and push an unreviewed image to a the images-dev repo. Maybe we need to create a second set of credentials gh-images-dev-deployer that can be activated instead?
What do you think?
That sounds appropriate! |
illusional
approved these changes
Apr 17, 2024
|
Delicious 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a bid to introduce better security permissions, we have replaced the use of SA keys to workload identity providers where possible. We will also ensure the workload federated identities are attached to an environment in the repo.
Changes
environmentattribute to thedockerworkflow