-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPG flow division #962
Draft
violetbrina
wants to merge
30
commits into
main
Choose a base branch
from
cpg-flow-division
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CPG flow division #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added region tags for the two unused methods and a modify for one method that has unused variables
…as some modifications for the Cohort.create_dataset that has an open ticket.
…oving across, fix the function call appropriately
…e or relocate to a utils.py file
…n workflow and stage code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
===========================================
- Coverage 78.42% 26.42% -52.00%
===========================================
Files 10 9 -1
Lines 1794 1680 -114
===========================================
- Hits 1407 444 -963
- Misses 387 1236 +849 ☔ View full report in Codecov by Sentry. |
…duction-pipelines into cpg-flow-division
…o tests/ directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch for documenting the division of code in production pipelines.
Not every file will be modified with region tags, as some files will be moved in their entirety as outlined in this spreadsheet.
For files that are labeled as
Modify
we are demarcating and noting changes in this PR in each individual file.