Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set batch to highmem workers slight job creation reorder #964

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

Alexander-Stuckey
Copy link
Contributor

Change the combiner to use highmem workers by default. Also only create the python job just before running, instead of the start, and then running some logic.

Set a constant to please SonarLint.

Copy link
Contributor

@MattWellie MattWellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all hail SonarLint

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.42%. Comparing base (fbad1ca) to head (322c276).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   26.42%   26.42%           
=======================================
  Files           9        9           
  Lines        1680     1680           
=======================================
  Hits          444      444           
  Misses       1236     1236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alexander-Stuckey Alexander-Stuckey merged commit 9ca3540 into main Oct 30, 2024
4 checks passed
@Alexander-Stuckey Alexander-Stuckey deleted the combiner-fixes branch October 30, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants