Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update merge_str_prep.py #84

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Update merge_str_prep.py #84

merged 3 commits into from
Aug 21, 2023

Conversation

hopedisastro
Copy link
Contributor

@hopedisastro hopedisastro commented Aug 20, 2023 •
edited
Loading

Main change is switching external-id command line argument for an internal-id

MattWellie
MattWellie approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@MattWellie MattWellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional syntax change, but fine to approve

str/trtools/merge_str_prep.py Outdated Show resolved Hide resolved
@hopedisastro @MattWellie
Update str/trtools/merge_str_prep.py
7b524ae 
Co-authored-by: Matt Welland <mattwellie@gmail.com>
@hopedisastro hopedisastro merged commit 0bc398d into main Aug 21, 2023
2 of 3 checks passed
@hopedisastro hopedisastro deleted the merge_str_prep_fix branch August 21, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattWellie MattWellie MattWellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopedisastro @MattWellie