Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction to clinvar no date supplied #313

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Correction to clinvar no date supplied #313

merged 3 commits into from
Aug 28, 2023

Conversation

MattWellie
Copy link
Collaborator

Fixes

  • Pedigree generation broken by graphQL change: participants dropped off if only one parent was present
  • ClinVar script doesn't handle no date being supplied

Proposed Changes

  • Fixes the itertools.product() call when generating pedigree rows
  • adds a default date to the clinvar output file
  • when the CI workflow automatically generates ClinVar summary data, it excludes MCRI entries

@MattWellie MattWellie merged commit c21ac60 into main Aug 28, 2023
5 checks passed
@MattWellie MattWellie deleted the correction-to-clinvar-no-date-supplied branch August 28, 2023 23:03
kdahlo pushed a commit to jeremiahwander/automated-interpretation-pipeline that referenced this pull request Dec 5, 2023
@MattWellie @kdahlo
Correction to clinvar no date supplied (populationgenomics#313)
58eed84 
* allow for None date to be passed thru

* Clinvar generation process removes VCGS subs

* adjustment to missing participants in pedigree generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassimons cassimons cassimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattWellie @cassimons