Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Latest-only report #315

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Additional Latest-only report #315

merged 12 commits into from
Aug 28, 2023

Conversation

MattWellie
Copy link
Collaborator

Fixes

  • Current report format doesn't make separating 'all' and 'latest only' variants easy
  • Some double counting was going on

Proposed Changes

  • Adds a second report, filtered to only the variants newly discovered in this run
  • Report index script now creates two HTML pages
    • One index contains the latest version of the report for each cohort, containing all variants
    • One index contains all 'latest only' reports, one for each interval
  • Cuts out a bunch of rubbish in the counting process

Checklist

  • Related Issue created
  • Tests covering new change
  • Linting checks pass

@MattWellie MattWellie merged commit f73ca36 into main Aug 28, 2023
4 checks passed
@MattWellie MattWellie deleted the latest_report_only branch August 28, 2023 23:07
kdahlo pushed a commit to jeremiahwander/automated-interpretation-pipeline that referenced this pull request Dec 5, 2023
@MattWellie @kdahlo
Additional Latest-only report (populationgenomics#315)
f8cd211 
* produce second filtered report

* update the report hunter

* Bump version: 1.1.4 → 1.1.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassimons cassimons cassimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattWellie @cassimons