Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constants to provider files #55

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

VallariAg
Copy link

Solves #34

Moved all the constants to provider files.

@elit-altum
Copy link
Contributor

@VallariAg Thank you for your contribution! 🎉

But this is not what we were looking for. We just wanted to move the constants file before to a new destination. We need the constants to be at a single place for reusability so other files can use it from there and on change, we won't have to make that change everywhere.

@VallariAg
Copy link
Author

@elit-altum

We just wanted to move the constants file before to a new destination.

I see, so do we just want to move the files from dashboard/lib/constants/ to dashboard/server/constants/?

Also, I'm interested to make more meaningful contributions to this project. Can you help me pick a ticket that I could work on?

@coditva
Copy link
Member

coditva commented Dec 21, 2021

@VallariAg @elit-altum Actually it would make sense for the files that are the "provider" of the constants to define and export them. The consumers (who call the APIs with the constant values) should import and use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants