Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants to provider files #55

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Move constants to provider files #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
847cacb
Move constants to provider files
VallariAg Nov 15, 2021
e237b7b
Remove /constants files
VallariAg Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions dashboard/lib/constants/frontend-events.js
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions dashboard/lib/constants/socket-events.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions dashboard/lib/constants/socket-rooms.js
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions dashboard/server/api/frontendApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
const {
ABORT_REQUEST,
PAUSE_REQUEST,
RESUME_REQUEST,
} = require('../../lib/constants/socket-events');
const PAUSE_REQUEST = 'pause';
const ABORT_REQUEST = 'abort';
const RESUME_REQUEST = 'resume';

module.exports = (socket) => ({
handlePauseRequest: (data, callback) => {
Expand Down
18 changes: 8 additions & 10 deletions dashboard/server/api/runApi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
const {
FRONTEND_ABORT_RUN,
FRONTEND_NEW_RUN,
FRONTEND_PAUSE_RUN,
FRONTEND_RESUME_RUN,
FRONTEND_RUN_EVENT,
FRONTEND_DONE_RUN,
FRONTEND_INTERRUPT_RUN,
FRONTEND_RUN_STATS,
} = require('../../lib/constants/frontend-events');
const FRONTEND_NEW_RUN = 'start';
const FRONTEND_PAUSE_RUN = 'pause';
const FRONTEND_ABORT_RUN = 'abort';
const FRONTEND_RESUME_RUN = 'resume';
const FRONTEND_DONE_RUN = 'done';
const FRONTEND_INTERRUPT_RUN = 'interrupt';
const FRONTEND_RUN_EVENT = 'run-event';
const FRONTEND_RUN_STATS = 'run-stats';

const controllers = require('../../lib/controllers/run');

Expand Down
38 changes: 18 additions & 20 deletions dashboard/server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,24 @@ const runHandlers = require('./api/runApi');
const frontendHandlers = require('./api/frontendApi');
const utils = require('../lib/utils');

const {
START_RUN,
PAUSE_RUN,
ABORT_RUN,
RESUME_RUN,
DONE_RUN,
INTERRUPT_RUN,
TEST_CONN,
RUN_EVENT,
RUN_STATS,
} = require('../lib/constants/socket-events');
const { NEWMAN_RUN, FRONTEND } = require('../lib/constants/socket-rooms');

const {
FRONTEND_REQUEST_ABORT,
FRONTEND_REQUEST_RESUME,
FRONTEND_REQUEST_PAUSE,
FRONTEND_REQUEST_TEST_CONN,
FRONTEND_REQUEST_TERMINATE,
} = require('../lib/constants/frontend-events');
const START_RUN = 'start';
const PAUSE_RUN = 'pause';
const ABORT_RUN = 'abort';
const RESUME_RUN = 'resume';
const DONE_RUN = 'done';
const INTERRUPT_RUN = 'interrupt';
const RUN_EVENT = 'run-event';
const RUN_STATS = 'run-stats';
const TEST_CONN = 'test';

const NEWMAN_RUN = 'newman-run';
const FRONTEND = 'frontend';

const FRONTEND_REQUEST_PAUSE = 'pause';
const FRONTEND_REQUEST_ABORT = 'abort';
const FRONTEND_REQUEST_RESUME = 'resume';
const FRONTEND_REQUEST_TERMINATE = 'terminate';
const FRONTEND_REQUEST_TEST_CONN = 'test';

const init = () => {
// setup socket.io server
Expand Down