-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libjpeg-turbo #7672
Use libjpeg-turbo #7672
Conversation
That is not true and the reason why we are seeing all the errors above. It is available from the |
.github/scripts/setup-env.sh
Outdated
# 1. `libjpeg-turbo` is only available for macOS and Windows on the `defaults` conda channel. Thus, we need to pull it | ||
# in from the `pytorch-nightly` channel on Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning, we can't just do conda install -c pytorch-nightly libjpeg-turbo
, since that won't work for Windows and macOS: https://anaconda.org/pytorch-nightly/libjpeg-turbo/files
We could either set the channel based on the OS, or let conda
figure it out automatically by proving both channels to the initial env creation.
I've opted for the latter for now. Let's see if CI is happy with it.
We have reverted the fixes I made since Still, note that CI is green for fd39e13 minus a few flaky tests. Meaning, it should work out smoothly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green. Thanks Nicolas!
Co-authored-by: Philip Meier <github.pmeier@posteo.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, we may need to build libjpeg-turbo for aarch64
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
(labelling as bug, not strictly the case but I want to make sure we advertize this properly in our release notes) |
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: matteobettini Differential Revision: D48642301 fbshipit-source-id: bbf318b1568fdc24796c4e6649d010bdfbd27a44
libjpeg-turbo is now available on the pytorch conda channel so we should be able to switch (at least for cuda builds).
Probably superseeds #5951
Addresses #7660