-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libjpeg-turbo #7672
Merged
Merged
Use libjpeg-turbo #7672
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
263cf43
Use turbo
NicolasHug 9917b49
fix installation in setup-env.sh script
pmeier 3ee8f61
fix
pmeier fd39e13
another fix
pmeier f4a3c2d
Revert "another fix"
NicolasHug d02d2c8
Revert "fix"
NicolasHug 421c7a7
Revert "fix installation in setup-env.sh script"
NicolasHug 1d1839e
Merge branch 'main' into turboooo
NicolasHug d662722
Merge branch 'main' into turboooo
NicolasHug 306dd10
Merge branch 'main' into turboooo
NicolasHug 2e66499
Merge branch 'main' of github.com:pytorch/vision into turboooo
NicolasHug 7efe97c
Some hacks
NicolasHug b391a6a
test all of test_image.py?
NicolasHug 4fdc43f
Add to smoke test
NicolasHug 70e8779
cleanups
NicolasHug 59530d3
Merge branch 'main' of github.com:pytorch/vision into turboooo
NicolasHug a0680da
Update .github/scripts/setup-env.sh
NicolasHug 69e4261
Merge branch 'main' into turboooo
NicolasHug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning, we can't just do
conda install -c pytorch-nightly libjpeg-turbo
, since that won't work for Windows and macOS: https://anaconda.org/pytorch-nightly/libjpeg-turbo/filesWe could either set the channel based on the OS, or let
conda
figure it out automatically by proving both channels to the initial env creation.I've opted for the latter for now. Let's see if CI is happy with it.