Skip to content

feat: add a quote reaction + text hint for removing quote embeds - #107

Open
michal-skraburski wants to merge 5 commits into
r-webdev:mainfrom
michal-skraburski:quote-embed-delete-hint
Open

feat: add a quote reaction + text hint for removing quote embeds#107
michal-skraburski wants to merge 5 commits into
r-webdev:mainfrom
michal-skraburski:quote-embed-delete-hint

Conversation

@michal-skraburski

@michal-skraburski michal-skraburski commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This feature hints to the user the quote embed can be deleted.

Previously, the user would link a message and the bot would reply to the message with an embed displaying the quoted message/image. It also supported deleting the embed but the current format of the embed would make no attempt to hint that it was possible to delete the embed.

I've made sure to test the feature actually works:

image

@wiktoriavh wiktoriavh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally code looks good to me, just slight changes needed.

makes me also wonder why not just add a button. there already is a button for "jump to message", why isn't there one for deleting the quote? why the workaround with an emoji? 🤔

);
if (found) {
existingField = found;
existingFieldEmbed = embed;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, you are just renaming embed to something else. could just use embed directly from what i see.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed, existingField is a field in the embed, existingFieldEmbed is the whole embed containing the specific field, which we're using later to check it's footer for the existing hint or add a new one.

Comment thread src/features/quote/embed.ts Outdated
@wiktoriavh

wiktoriavh commented Aug 29, 2026

Copy link
Copy Markdown
Member

Also if it is for a ticket, include the ticket number in the pr title and in the body, like so:

Title: feat(#123): foo bar
Body: Closes #123

Github will then automatically connect pr to issue and auto close the issue if it gets merged.

@hmd-ali

hmd-ali commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

generally code looks good to me, just slight changes needed.

makes me also wonder why not just add a button. there already is a button for "jump to message", why isn't there one for deleting the quote? why the workaround with an emoji? 🤔

A button would draw too much attention, this is meant to be subtle. Only the user who triggered the quote should be able to delete it, and I didn't want a destructive looking button visible to everyone else who sees the message. That's why I suggested a small hint in the footer instead. It's discoverable if you're looking for it, but it doesn't compete visually with the rest of the embed the way a full button would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants