Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests deterministic #16910

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

This PR is a first pass of making tests deterministic, I noticed one of CI job failed due to an overflow error related to random data generation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 25, 2024
@galipremsagar galipremsagar self-assigned this Sep 25, 2024
@galipremsagar galipremsagar requested review from a team as code owners September 25, 2024 14:11
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 25, 2024
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2024
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dask changes LGTM. Thanks!

@galipremsagar
Copy link
Contributor Author

/merge

Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but going forward it would be good to start using numpy's new, recommended numpy.random.Generator API https://numpy.org/doc/stable/reference/random/generator.html#numpy.random.Generator

@rapids-bot rapids-bot bot merged commit ba4afae into rapidsai:branch-24.10 Sep 25, 2024
96 checks passed
@galipremsagar
Copy link
Contributor Author

Not a blocker, but going forward it would be good to start using numpy's new, recommended numpy.random.Generator API https://numpy.org/doc/stable/reference/random/generator.html#numpy.random.Generator

Good point. Noted 👍

@jakirkham
Copy link
Member

It is worth noting that this is covered by Ruff's rule NPY002. We may want to consider adding that to this list

cudf/pyproject.toml

Lines 28 to 32 in ba4afae

[tool.ruff.lint]
typing-modules = ["cudf._typing"]
select = [
# pycodestyle Error
"E",


On a more general note, we are discussing the value of enabling more Ruff rules for NumPy across RAPIDS in issue: rapidsai/build-planning#103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants