-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests deterministic #16910
Make tests deterministic #16910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dask changes LGTM. Thanks!
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but going forward it would be good to start using numpy's new, recommended numpy.random.Generator
API https://numpy.org/doc/stable/reference/random/generator.html#numpy.random.Generator
Good point. Noted 👍 |
It is worth noting that this is covered by Ruff's rule Lines 28 to 32 in ba4afae
On a more general note, we are discussing the value of enabling more Ruff rules for NumPy across RAPIDS in issue: rapidsai/build-planning#103 |
Description
This PR is a first pass of making tests deterministic, I noticed one of CI job failed due to an overflow error related to random data generation.
Checklist