-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12, update to umap-learn==0.5.6 #6060
Conversation
@@ -509,7 +513,7 @@ dependencies: | |||
- seaborn | |||
- *scikit_learn | |||
- statsmodels | |||
- umap-learn==0.5.3 | |||
- umap-learn==0.5.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umap-learn==0.5.3
does not have Python 3.12 packages on conda-forge
, resulting in these build errors:
LibMambaUnsatisfiableError: Encountered problems while solving:
- package umap-learn-0.5.3-py310hff52083_0 requires python_abi 3.10.* *_cp310, but none of the providers can be installed
Could not solve for environment specs
The following packages are incompatible
...
└─ umap-learn 0.5.3 is not installable because there are no viable options
├─ umap-learn 0.5.3 would require
│ └─ python_abi 3.10.* *_cp310, which conflicts with any installable versions previously reported;
├─ umap-learn 0.5.3 would require
│ └─ python_abi 3.7.* *_cp37m, which conflicts with any installable versions previously reported;
├─ umap-learn 0.5.3 would require
│ └─ python_abi 3.8.* *_cp38, which conflicts with any installable versions previously reported;
├─ umap-learn 0.5.3 would require
│ └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported;
└─ umap-learn 0.5.3 would require
└─ python_abi 3.11.* *_cp311, which conflicts with any installable versions previously reported.
Proposing updating to the latest version (0.5.6).
Restarted CI here now that there are Python 3.12 packages for Will put this up for review once I see enough of CI passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm going to trigger a /merge
before I end for the day, I see some Python 3.12 CI jobs passing so I'm hopeful this is going to work.
/merge |
Thanks so much for all the help with this @bdice ! |
/merge |
…711) Contributes to rapidsai/build-planning#40. * adds Python 3.12 images * defaults to latest Python (3.12) and CUDA (12.5[.1]) in docs and comments ## Notes for Reviewers Builds here will fail until all RAPIDS libraries are supporting Python 3.12, but figured we don't need to wait on that to come to an agreement about the building and testing matrices. Blocked by: * [x] rapidsai/cuml#6060 * [x] rapidsai/cugraph#4647 * [x] rapidsai/integration#719 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #711
Description
Contributes to rapidsai/build-planning#40
This PR adds support for Python 3.12.
Other changes required for this:
umap-learn
,0.5.3 -> 0.5.6
(https://github.com/rapidsai/cuml/pull/6060/files#r1745915933)Notes for Reviewers
This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.
A follow-up PR will revert back to pointing at the
branch-24.10
branch ofshared-workflows
once allRAPIDS repos have added Python 3.12 support.
This will fail until all dependencies have been updates to Python 3.12
CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.
This can be merged whenever all CI jobs are passing.