-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input to enable testing #565
Conversation
@@ -2,7 +2,7 @@ pull-request: | |||
- { CUDA_VER: '11.2.2', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' } | |||
- { CUDA_VER: '12.0.1', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' } | |||
- { CUDA_VER: '11.8.0', ARCH: 'arm64', PYTHON_VER: '3.10', GPU: 'a100', DRIVER: 'latest' } | |||
nightly: | |||
branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was the reason for switching this key from nightly
to branch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nevermind. I see.
it's used as the key here: https://github.com/raydouglass/docker/blob/b7542b9d46badcb3dec468f0b1c09d11c54474c5/.github/workflows/build-test-publish-images.yml#L96
Will this get switched back to nightly
after the build and test workflows are split up as mentioned in rapidsai/workflows#29?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the calling workflows use branch
for the build_type
and that's the key that is looked up in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, posted before refreshing.
Will this get switched back to nightly
Yes, I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, filed an issue: #566
/merge |
Adds `rapidsai/docker` to the nightly pipeline. This implementation differs from other repositories because the `docker` repo workflows combine build & test in a single workflow due to using temporary images during testing. I think a future enhancement should be to refactor the `docker` workflows to allow for split builds and tests which would be more flexible. Depends on rapidsai/docker#565
Refactoring how tests are triggered to use an input. This will allow a calling workflow in
rapidsai/actions
to execute the notebook tests on a nightly basis.