Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input to enable testing #565

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Conversation

raydouglass
Copy link
Member

Refactoring how tests are triggered to use an input. This will allow a calling workflow in rapidsai/actions to execute the notebook tests on a nightly basis.

@raydouglass raydouglass marked this pull request as ready for review August 2, 2023 19:21
@raydouglass raydouglass requested a review from a team as a code owner August 2, 2023 19:21
@@ -2,7 +2,7 @@ pull-request:
- { CUDA_VER: '11.2.2', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' }
- { CUDA_VER: '12.0.1', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '11.8.0', ARCH: 'arm64', PYTHON_VER: '3.10', GPU: 'a100', DRIVER: 'latest' }
nightly:
branch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reason for switching this key from nightly to branch?

Copy link
Member

@ajschmidt8 ajschmidt8 Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nevermind. I see.

it's used as the key here: https://github.com/raydouglass/docker/blob/b7542b9d46badcb3dec468f0b1c09d11c54474c5/.github/workflows/build-test-publish-images.yml#L96

Will this get switched back to nightly after the build and test workflows are split up as mentioned in rapidsai/workflows#29?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the calling workflows use branch for the build_type and that's the key that is looked up in this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, posted before refreshing.

Will this get switched back to nightly

Yes, I think so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, filed an issue: #566

@raydouglass
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8733d50 into rapidsai:branch-23.08 Aug 4, 2023
9 checks passed
@raydouglass raydouglass deleted the nightlies branch August 4, 2023 16:40
raydouglass added a commit to rapidsai/workflows that referenced this pull request Aug 4, 2023
Adds `rapidsai/docker` to the nightly pipeline.

This implementation differs from other repositories because the `docker`
repo workflows combine build & test in a single workflow due to using
temporary images during testing. I think a future enhancement should be
to refactor the `docker` workflows to allow for split builds and tests
which would be more flexible.

Depends on rapidsai/docker#565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants