Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input to enable testing #565

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Add input to enable testing #565

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef93b1a
Add input to enable testing
raydouglass Aug 2, 2023
b7542b9
Update test matrix key
raydouglass Aug 2, 2023
9b83efb
Update configure-aws-credentials tag
raydouglass Aug 2, 2023
e7f3263
Merge remote-tracking branch 'upstream/branch-23.08' into nightlies
raydouglass Aug 4, 2023
c509813
build-multiarch-manifest should run without tests
raydouglass Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build-test-publish-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
build_type:
required: true
type: string
run_tests:
required: false
default: false
type: boolean

defaults:
run:
Expand Down Expand Up @@ -123,8 +127,7 @@ jobs:
py${{ matrix.PYTHON_VER }}"
test:
needs: [build, compute-matrix]
# TODO: nightly tests
if: inputs.build_type == 'pull-request'
if: inputs.run_tests
strategy:
matrix: ${{ fromJSON(needs.compute-matrix.outputs.TEST_MATRIX) }}
fail-fast: false
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ jobs:
uses: ./.github/workflows/build-test-publish-images.yml
with:
build_type: pull-request
run_tests: true
secrets: inherit
6 changes: 6 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
tags:
- v[0-9][0-9].[0-9][0-9].[0-9][0-9]
workflow_dispatch:
inputs:
run_tests:
required: false
default: false
type: boolean

concurrency:
group: "${{ github.workflow }} @ ${{ github.ref }}"
Expand All @@ -17,6 +22,7 @@ jobs:
uses: ./.github/workflows/build-test-publish-images.yml
with:
build_type: branch
run_tests: ${{ inputs.run_tests || false }}
secrets: inherit
readme:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion matrix-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ pull-request:
- { CUDA_VER: '11.2.2', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' }
- { CUDA_VER: '12.0.1', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '11.8.0', ARCH: 'arm64', PYTHON_VER: '3.10', GPU: 'a100', DRIVER: 'latest' }
nightly:
branch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reason for switching this key from nightly to branch?

Copy link
Member

@ajschmidt8 ajschmidt8 Aug 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nevermind. I see.

it's used as the key here: https://github.com/raydouglass/docker/blob/b7542b9d46badcb3dec468f0b1c09d11c54474c5/.github/workflows/build-test-publish-images.yml#L96

Will this get switched back to nightly after the build and test workflows are split up as mentioned in rapidsai/workflows#29?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the calling workflows use branch for the build_type and that's the key that is looked up in this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, posted before refreshing.

Will this get switched back to nightly

Yes, I think so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, filed an issue: #566

- { CUDA_VER: '11.2.2', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'earliest' }
- { CUDA_VER: '11.2.2', ARCH: 'amd64', PYTHON_VER: '3.9', GPU: 'v100', DRIVER: 'latest' }
- { CUDA_VER: '11.8.0', ARCH: 'amd64', PYTHON_VER: '3.10', GPU: 'v100', DRIVER: 'latest' }
Expand Down
Loading