acendan: Initial commit. Add ReaScript API: AC_GetMediaFileCoverImage() #1658
Conversation
|
✅ Build sws 760-master completed (commit 48360cddc2 by @acendan) Windows 64-bitWindows 32-bitmacOS x86 64-bitmacOS x86 32-bitmacOS ARM 64-bitLinux x86 64-bitLinux x86 32-bitLinux ARM 64-bitLinux ARM 32-bit |
acendan/acendan.cpp
Outdated
| const auto& coverPath = acendan::player.GetCoverPath(); | ||
| if (!coverPath.empty()) | ||
| { | ||
| std::copy(coverPath.c_str(), coverPath.c_str() + temppathOut_sz, temppathOut); |
There was a problem hiding this comment.
This copies temppathOut_sz (typically 1024 bytes) even if the cover path is shorter (buffer over-read).
| std::copy(coverPath.c_str(), coverPath.c_str() + temppathOut_sz, temppathOut); | |
| snprintf(temppathOut, temppathOut_sz, "%s", coverPath.c_str()); |
(or limit to coverPath.size() + 1)
|
Also some more general things:
|
Was previously relying on wstrings for file I/O, but no longer needed for character encoding conversions. acendan: Initial commit. Add ReaScript API: AC_GetMediaFileCoverImage() Tested: Win10, OSX 10.14.6, Linux Mint Swap std::copy for snprintf. Add newline to end of files. reaper-oss#1658 (comment)
Looking into this right now, so forgive my unfamiliarity with GitHub PRs. When editing the PR, I can use a new branch from my fork, called 'acendan'. However, I'm still only seeing the option to submit the request to SWS's master branch. How should I go about creating a new branch in sws? Here's a draft of the new PR (not actually submitted for review yet): #1662. It's the same thing, but from a branch acendan:acendan, rather than acendan:master. That appears to be the extent of the branch-related flexibility on my end. Refer to screenshot below; can't edit the base repository's target branch field. |
|
@acendan |
|
@nofishonfriday No worries! Thanks for the explanation. Closed this PR and opened up the new one, at: #1662 Cheers 😄 |
|
Btw. not sure if you're familiar with it, if you want to make further changes to your PR without creating a new commit you can amend the last (most recent) commit. |
AC_GetMediaFileCoverImage
Description: This function uses TagLib to fetch the embedded image from an audio file. It then writes that image to a temp jpeg file using native OS-specific temp file implementation. The image can then be used via ReaScript API to, for example, display the embedded image for a selected media item. It could also be copied and saved locally as an image file, if desired.
Tested: Win10, OSX 10.14.6, Linux Mint
Win10
OSX 10.14.6
Linux Mint
