acendan: Add ReaScript API: AC_GetMediaFileCoverImage() #1662
Conversation
Was previously relying on wstrings for file I/O, but no longer needed for character encoding conversions. acendan: Initial commit. Add ReaScript API: AC_GetMediaFileCoverImage() Tested: Win10, OSX 10.14.6, Linux Mint Swap std::copy for snprintf. Add newline to end of files. reaper-oss#1658 (comment)
|
✅ Build sws 763-master completed (commit 5f4d3b5389 by @acendan) Windows 64-bitWindows 32-bitmacOS x86 64-bitmacOS x86 32-bitmacOS ARM 64-bitLinux x86 64-bitLinux x86 32-bitLinux ARM 64-bitLinux ARM 32-bit |
acendan
changed the title
|
Bump! @cfillion @nofishonfriday Just bringing visibility to the new PR. |
|
@acendan Just in case you're wondering, SWS dev happens rather slowly usually (last official release was February 06, 2021, pre-releases hapen a bit more frequently), but your PR will be processed and merged eventually. :) |
|
No worries! Crazy to think that last official was over 1.5 years ago at this point. Cheers |
| // APE: https://www.monkeysaudio.com/developers.html | ||
| bool ExtractCoverAPE(TagLib::APE::Tag* tag, const std::string& target) | ||
| { | ||
| const TagLib::APE::ItemListMap& listMap = tag->itemListMap(); |
There was a problem hiding this comment.
..\acendan\cover.cpp(160): warning C4996: 'TagLib::MP4::ItemListMap': was declared deprecated
..\acendan\cover.cpp(160): warning C4996: 'TagLib::MP4::Tag::itemListMap': was declared deprecated
| const TagLib::APE::ItemListMap& listMap = tag->itemListMap(); | |
| const TagLib::APE::ItemMap& listMap = tag->itemMap(); |
https://taglib.org/api/classTagLib_1_1MP4_1_1Tag.html#ab4ef785d36d566f5bd23d12ac3d8b804
| std::string GetTempFilePath(const std::string& extension = ".jpg") | ||
| { | ||
| char buffer[L_tmpnam]; | ||
| tmpnam(buffer); |
There was a problem hiding this comment.
/home/appveyor/projects/sws/acendan/cover.cpp:68:9: warning: ignoring return value of ‘char* tmpnam(char*)’, declared with attribute warn_unused_result [-Wunused-result]
| tmpnam(buffer); | |
| (void)!tmpnam(buffer); |
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425#c34
In function `_GLOBAL__sub_I_acendan.cpp.lto_priv.1285':
:(.text.startup+0xf4): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
...which is because it's technically not 100% impossible for another program to use that same temporary name for themselves between the call to tmpnam and when the file is actually created afterwards.
Perhaps this could instead use a known safe & writable path in the user's resource directory (eg. GetResourcePath() + WDL_DIRCHAR_STR "sws_tmpcover.jpg"), or maybe even letting the caller of the API provide a path themselves?
(Or just return the picture data, letting the caller deal with writing to a file/do any other processing they want? realloc_cmd_ptr on the output buffer to send a binary-safe string.)
Are cover pictures always JPEG?
There was a problem hiding this comment.
Are cover pictures always JPEG?
MP3 tag windows app allows to pick JPEG, JFIF, PNG and WEBP when adding a cover image. No sure if it is standard definition, but we can expect it to be at least JPEG / PNG.
This PR is largely identical to the original PR, with the only difference being the branch acendan:acendan, as opposed to acendan:master (per this comment from @nofishonfriday).
This PR includes the squashed commit with:
#include <codecvt>, was previously relying on wstrings for file I/O, but no longer needed for character encoding conversions.Tested: Win10, OSX 10.14.6, Linux Mint