Simplify WARL description for dmode=0 and action=1. #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sdtrig.adoc
Outdated
Comment on lines
60
to
62
| This action is only legal when the trigger's {mcontrol-dmode} is 1. Since the | ||
| {csr-tdata1} is WARL, hardware must prevent it from containing {tdata1-dmode}=0 | ||
| and action=1. + |
There was a problem hiding this comment.
Suggested change
| This action is only legal when the trigger's {mcontrol-dmode} is 1. Since the | |
| {csr-tdata1} is WARL, hardware must prevent it from containing {tdata1-dmode}=0 | |
| and action=1. + | |
| This action is only legal when the trigger's {mcontrol-dmode} is 1. Since | |
| {csr-tdata1} is WARL, hardware must prevent it from containing {tdata1-dmode}=0 | |
| and action=1. + |
Or "the tdata1 register" would also be OK.
Instead of describing a recommended implementation (which didn't cover all cases), explicitly state the value that is illegal and let hardware choose how to do that. Addresses #995.
pdonahue-ventana
approved these changes
Apr 25, 2024
|
This introduces a new "must", but that is OK because it's simply restating something about a field that is only legal in certain cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of describing a recommended implementation (which didn't cover all cases), explicitly state the value that is illegal and let hardware choose how to do that.
Addresses #995.