Clarify that DMI nop does not affect busy/error. #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The confusion was raised in the 2024-07-08 meeting.
|
I considered changing "should" to "must" but does that then make it backwards incompatible? I really hope there are no implementations that have "nop" affect these status bits, though. It would break all kinds of things. So maybe should->must would be a bug fix? |
pdonahue-ventana
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
What you have is good. I think that "must" is probably better but I worry about going through reviews, delaying ratification, etc. This isn't a "stop the presses" moment so I'm inclined to go with what's here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confusion was raised in the 2024-07-08 meeting.