Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sw instruction assembly in Appendix A.2 #1059

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix sw instruction assembly in Appendix A.2 #1059

merged 1 commit into from
Aug 13, 2024

Conversation

tienntr
Copy link
Contributor

@tienntr tienntr commented Aug 13, 2024

sw 0x400(zero), <gpr> has incorrect assembly syntax, source register should come first.

@tienntr
Fix sw instruction assembly in Appendix A.2
5c91386 
`sw 0x400(zero), <gpr>` has incorrect assembly syntax, source register
should come first.
pdonahue-ventana
pdonahue-ventana approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@rtwfroody rtwfroody merged commit 64ef63d into riscv:main Aug 13, 2024
1 check passed
@tienntr tienntr deleted the patch-1 branch September 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonahue-ventana pdonahue-ventana pdonahue-ventana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienntr @pdonahue-ventana @rtwfroody