Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Fortress gz packages #169

Merged
merged 20 commits into from
Aug 26, 2022
Merged

Import Fortress gz packages #169

merged 20 commits into from
Aug 26, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 17, 2022

Summary:

  • Add all gz counterparts to ignition packages
  • Bump to the latest releases. ⚠️ I've included some versions that are staged to be released, but not there yet:
    • gz-sim 6.11.0-2
    • gz-utils 1.4.0-2
  • I didn't update Buster on purpose, because that's EOL and we haven't been making new releases for it

Here's the current status of Fortress source packages on packages.osrf (this doesn't check that the gz packages exist, I've done that manually 🙃 ):

image

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@nuclearsandwich
Copy link
Contributor

(this doesn't check that the gz packages exist, I've done that manuall

According to the generator script libgz-transport11-cli is still outstanding:
@j-rivero do you know which debbuilder job is responsible for this package?

libgz-transport11-cli 11.2.0-2~focal in gz-transport11-cli does not match expected version 11.2.0-3~focal

@nuclearsandwich nuclearsandwich marked this pull request as ready for review August 18, 2022 00:02
@j-rivero
Copy link
Contributor

According to the generator script libgz-transport11-cli is still outstanding:
@j-rivero do you know which debbuilder job is responsible for this package?

libgz-transport11-cli was an error and a wrong package produced by the error that really should have been gz-transport11-cli. Should not be imported.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I've just pushed a bunch of my own changes that will be good for @j-rivero to look over. I think this is now ready to go once the Citadel PR (#168) it's based on is merged.

Most of my changes were specifically related to updating to the latest version available in the gazebo repositories which is absolutely necessary for a successful complete import and including addition gz packages which have been added. In one case, I removed listed gz packages which are not present in the upstream repository.

Base automatically changed from chapulina/citadel_gz to master August 25, 2022 21:30
@j-rivero
Copy link
Contributor

CI is happy, script in #144 is happy. Merging.

@j-rivero j-rivero merged commit 86c0716 into master Aug 26, 2022
@j-rivero j-rivero deleted the chapulina/fortress_gz branch August 26, 2022 19:02
@j-rivero
Copy link
Contributor

@nuclearsandwich
Copy link
Contributor

Imported https://build.ros2.org/job/import_upstream/419/

In the future please run import_upstream for both build farms regardless of which one is "targeted" by a chance in order to reduce noise in other import jobs related to these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants