Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gz keys for Gazebo Citadel and Fortress #34177

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

chapulina
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

Gazebo

Package Upstream Source:

All packages are on this org: https://github.com/gazebosim/

Purpose of using this:

Gazebo is being renamed from Ignition back to Gazebo. The Gazebo team will keep supporting the ignition name for Citadel and Fortress until they reach end of life, but we're providing gz aliases so the community can start using the new name and future-proof their packages.

Once the rosdep keys are available, we'll update packages like ros_gz and gz_ros2_control to use the new keys, and we encourage the community to do the same.

Links to Distribution Packages

@chapulina chapulina requested a review from a team as a code owner August 17, 2022 22:37
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Aug 17, 2022
@adityapande-1995
Copy link
Contributor

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to add, we're just waiting on the import first though.

@nuclearsandwich
Copy link
Member

The current failure doesn't appear related to the this PR.

 ERROR: test.test_build_caches.test_build_caches
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/runner/work/rosdistro/rosdistro/test/test_build_caches.py", line 57, in test_build_caches
    raise RuntimeError('\n'.join(errors))
RuntimeError: noetic: missing package.xml file for package "mocap_nokov"

It may be resolved by rebasing these changes onto the latest master.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

Rebased

@nuclearsandwich
Copy link
Member

Just because we're trying to finish this on a Friday. GitHub availability problems are gonna make this hard.

======================================================================
ERROR: test_suggest_by_name (test.rosdep_repo_check.test_rosdep_repo_check.TestRosdepRepositoryCheck)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/urllib/request.py", line 1354, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 1256, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 1302, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 1251, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 1011, in _send_output
    self.send(msg)
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 951, in send
    self.connect()
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/http/client.py", line 922, in connect
    self.sock = self._create_connection(
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/socket.py", line 808, in create_connection
    raise err
  File "/opt/hostedtoolcache/Python/3.8.13/x64/lib/python3.8/socket.py", line 796, in create_connection
    sock.connect(sa)
OSError: [Errno 101] Network is unreachable

During handling of the above exception, another exception occurred:

@nuclearsandwich
Copy link
Member

These look good to add, we're just waiting on the import first though.

Treating this as the first ✔️ review which means that together with mine this is ready to merge.

@nuclearsandwich nuclearsandwich merged commit 83a128e into ros:master Sep 2, 2022
@chapulina chapulina deleted the chapulina/gz branch September 2, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants