Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/diagnostic_updater/DiagnosticTaskVector: added virtual destructor #88

Open
wants to merge 1 commit into
base: indigo-devel
Choose a base branch
from

Conversation

cwecht
Copy link

@cwecht cwecht commented Oct 2, 2018

This fixes a 'has virtual functions and accessible non-virtual destructor'-warning.

@mikepurvis
Copy link
Member

👍

@trainman419
Copy link
Contributor

As awesome as this is, it's also an ABI-breaking change. I'll probably need to hold it until the next major ROS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros1 PR tackling a ROS1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants