Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] Add pause and resume service calls for rosbag2 recorder (Backport #1131) #1453

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

haudren-woven
Copy link

I have found a need to start & stop recording in my Humble installation. I figured that the services already exist in rosbag2_interfaces, so backporting is a very easy job. There were a couple of conflicts to manually resolve, which prevented me from going through Mergify.

Let me know if this is appropriate!

* feat(recorder): Add pause and resume service calls.

Add service calls to pause recording and resume recording.

Fixes ros2#1130

Signed-off-by: Rick Shanor <rickshanor@gmail.com>

* feat(recorder): pause, resume, and is_paused PR comments.

Address PR comments. Add is_paused service. Update tests accordingly.

Signed-off-by: Rick Shanor <rickshanor@gmail.com>

Signed-off-by: Rick Shanor <rickshanor@gmail.com>
@haudren-woven haudren-woven requested a review from a team as a code owner August 24, 2023 07:08
@haudren-woven haudren-woven requested review from MichaelOrlov and hidmic and removed request for a team August 24, 2023 07:08
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big problem in general with this backport is that it changes ABI by adding members to the Recorder class. Since our policy is to never break ABI in stable distributions, this is a problem.

One way to get around this is to to add in a global map of Recorder pointers to a structure containing the pieces you need. You can see an example of this pattern in ros2/rclcpp#2236 (look for the BackportMembers class).

@MichaelOrlov MichaelOrlov changed the title Add pause and resume service calls for rosbag2 recorder (Backport #1131 -> Humble) []humble Add pause and resume service calls for rosbag2 recorder (Backport #1131) Sep 15, 2023
@MichaelOrlov MichaelOrlov changed the title []humble Add pause and resume service calls for rosbag2 recorder (Backport #1131) [humble] Add pause and resume service calls for rosbag2 recorder (Backport #1131) Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants