Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] More precise type hints for rosbag2_py #1463

Draft
wants to merge 8 commits into
base: humble
Choose a base branch
from

Conversation

MichaelFishmanBDAII
Copy link

@MichaelFishmanBDAII MichaelFishmanBDAII commented Sep 8, 2023

VERY WIP

Meant to address #1459

For now, the only improved type hint is for SequentialReader.read_next and the type stubs need to be generated manually.

This branch has many other changes I made to make development easier for me. I'm guessing rosbag2 doesn't actually want them, in which case they'd be removed before this PR is un-drafted.
These changes are:

  1. .devcontainer and Dockerfile. Currently these mention my username. If the devcontainer is kept, I'd remove that username-specific bit. These were made following this guide for getting ROS2 in a devcontainer.
  2. The tests for rosbag2_py now use unittest.TestCase, so that I can run them from the VSCode test panel, without running the entire colcon test.
  3. I removed the .github workflows (you definitely don't want this change)

@MichaelOrlov MichaelOrlov changed the title More precise type hints for rosbag2_py [wip] More precise type hints for rosbag2_py Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant