Fixes Wings migration of based_near attribute in to_resource #6922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Native Valkyrie objects contain a URI string, not an RDF::URI - Fedora contains Hyrax::ControlledVocabularies::Location objects Modifies the behavior of the `based_near` attribute in the `to_resource` and `from_resource` methods. When using wings to convert between resources & fedora works, we were previously storing the RDF::URI in Valkyrie. This PR updates the behavior to consistently return values consistent with what would be seen in native objects.
Test Results 17 files 17 suites 2h 18m 43s ⏱️ Results for commit 3d679fd. ♻️ This comment has been updated with latest results. |
This may still be needed, but this doesn't work correctly. A ticket has been created for this bug if this is something that is ever needed. #6926
laritakr
changed the title
orangewolf
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Re:
based_nearattribute:When using wings to lazy migrate between resources & fedora works, we were previously storing the location as an RDF::URI in Valkyrie.
Summary
Updates the behavior of the
based_nearattribute in theto_resourcemethod to return values consistent with native objects.Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
bug fix
Detailed Description
This PR modifies the behavior of the
based_nearattribute in theto_resourcemethod. We now return values consistent with what would be seen in native objects.Changes proposed in this pull request:
to_resourceon a fedora object object, thebased_nearattribute will be a URI string.@samvera/hyrax-code-reviewers
Notes
Related bug ticket #6926 for going the other direction.