-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Wings migration of based_near attribute in to_resource #6922
Merged
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e379be - Browse repository at this point
Copy the full SHA 1e379beView commit details -
Maps location for wings migrations
- Native Valkyrie objects contain a URI string, not an RDF::URI - Fedora contains Hyrax::ControlledVocabularies::Location objects Modifies the behavior of the `based_near` attribute in the `to_resource` and `from_resource` methods. When using wings to convert between resources & fedora works, we were previously storing the RDF::URI in Valkyrie. This PR updates the behavior to consistently return values consistent with what would be seen in native objects.
Configuration menu - View commit details
-
Copy full SHA for a89b634 - Browse repository at this point
Copy the full SHA a89b634View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ee2bf - Browse repository at this point
Copy the full SHA a0ee2bfView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0635b70 - Browse repository at this point
Copy the full SHA 0635b70View commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6972df0 - Browse repository at this point
Copy the full SHA 6972df0View commit details -
Undo Active Fedora conversion of based_near
This may still be needed, but this doesn't work correctly. A ticket has been created for this bug if this is something that is ever needed. #6926
Configuration menu - View commit details
-
Copy full SHA for cc7902c - Browse repository at this point
Copy the full SHA cc7902cView commit details -
Merge branch 'migrate_based_near' of github.com:samvera/hyrax into mi…
…grate_based_near
Configuration menu - View commit details
-
Copy full SHA for 1385de2 - Browse repository at this point
Copy the full SHA 1385de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d679fd - Browse repository at this point
Copy the full SHA 3d679fdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.