Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Wings migration of based_near attribute in to_resource #6922

Merged
merged 8 commits into from
Oct 16, 2024

Commits on Oct 11, 2024

  1. Add failing specs to fix

    laritakr committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1e379be View commit details
    Browse the repository at this point in the history
  2. Maps location for wings migrations

    - Native Valkyrie objects contain a URI string, not an RDF::URI
    - Fedora contains Hyrax::ControlledVocabularies::Location objects
    
    Modifies the behavior of the `based_near` attribute in the `to_resource`
    and `from_resource` methods. When using wings to convert between
    resources & fedora works, we were previously storing the RDF::URI in
    Valkyrie. This PR updates the behavior to consistently return values
    consistent with what would be seen in native objects.
    laritakr committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a89b634 View commit details
    Browse the repository at this point in the history
  3. Pacify the cops

    laritakr committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a0ee2bf View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    0635b70 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    6972df0 View commit details
    Browse the repository at this point in the history
  2. Undo Active Fedora conversion of based_near

    This may still be needed, but this doesn't work correctly.
    A ticket has been created for this bug if this is something that is
    ever needed.
    
    #6926
    laritakr committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cc7902c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1385de2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3d679fd View commit details
    Browse the repository at this point in the history