Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryFrom<HttpRequest<()>> for Request #2196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gerhut
Copy link

@Gerhut Gerhut commented Mar 21, 2024

http::Request<()> is a common pattern of requests without body in the http library, but it cannot be converted into reqwest::Request. This PR adds such case.

@Gerhut Gerhut force-pushed the try_from_http_request_without_body branch from de4409a to ef89c85 Compare March 22, 2024 03:02
@rlidwka
Copy link

rlidwka commented Jun 4, 2024

in #2307, I did another implementation, which is much simpler, but stores body differently (None vs Some(Bytes::empty())), please check it out and give comment if any

I did my own investigation into this issue before I found this PR, so I'd be happy if either one is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants