New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve interop with `http::Request<()>` #2307

Open

rlidwka wants to merge 1 commit into seanmonstar:master from rlidwka:empty-body

rlidwka commented Jun 4, 2024

see #2196 for reasons why, and to make sure that I'm not the only crazy person who needs this

I need impl TryFrom<HttpRequest<()>> for Request, which already exists for T: Into<Body>:

reqwest/src/async_impl/request.rs

Lines 598 to 601 in 695bc04

    
           impl<T> TryFrom<HttpRequest<T>> for Request 
        
           where 
        
               T: Into<Body>, 
        
           {

only thing we need to do is make sure that (): Into<Body>, which is what this PR does


          feat: add impl From<()> for Body

a810960

rlidwka mentioned this pull request

Add TryFrom<HttpRequest<()>> for Request #2196

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet