fix: Fix compilation on Arch Linux #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joeyparrish
commented
Jul 14, 2023
•
joeyparrish
commented
- Update protobuf to v23.4, to fix the cstdint error on Arch Linux, and make some related changes:
- Silence additional compiler warnings for the new protobuf
- Update absl to 20230125.3, to support the protobuf update, and make some related changes:
- Silence additional compiler warnings for the new protobuf
- Replace GOOGLE_CHECK_OK with ABSL_CHECK_OK
- Replace GUARDED_BY with ABSL_GUARDED_BY
- Update other instances of cstdint missing in our own code
- Always pull the latest docker images, to avoid stale results when your workstation has pulled an older image at the same label
- Update protobuf to v23.4, to fix the cstdint error on Arch Linux, and make some related changes: - Silence additional compiler warnings for the new protobuf - Update absl to 20230125.3, to support the protobuf update, and absorb some macro changes in absl: - Replace GOOGLE_CHECK_OK with ABSL_CHECK_OK - Replace GUARDED_BY with ABSL_GUARDED_BY - Update other instances of cstdint missing in our own code - Always pull the latest docker images, to avoid stale results when your workstation has pulled an older image at the same label
|
Windows tests are failing with another warning that needs to be silenced in protobuf
|
kqyang
approved these changes
Jul 14, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.