Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-arrange sigstore docs so that they are more clear to readers #210

Merged
merged 188 commits into from
Aug 11, 2023

Conversation

hayleycd
Copy link
Contributor

@hayleycd hayleycd commented Aug 7, 2023

Addresses issue #191

Summary

Reorganize documentation. Please see any comments by @jonvnadelberg.

I opened this pull request to solve a git issue, but he did the work. (This replaces #209 which had the git issues)

Release Note

None

Documentation

This is a documentation change.

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
…rs.md

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
…elf-managed_keys.md

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
jonvnadelberg and others added 10 commits July 30, 2023 13:37
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
fix logo name

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
first section of redirects

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
done up through cosign with redirects.

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
complete redirects from old version of sigstore to new 

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: Hayley Denbraver <denbraver@google.com>
Signed-off-by: Hayley Denbraver <denbraver@google.com>
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit beb2b34
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/64d65ca4a77a67000802dd39
😎 Deploy Preview https://deploy-preview-210--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hayleycd hayleycd changed the title Update sigstore copy Re-arrange sigstore docs so that they are more clear to readers Aug 7, 2023
Undoing the original commit because we don't actually want to change the readme. 

Signed-off-by: Hayley Denbraver <denbraver@google.com>
@olivekl
Copy link
Contributor

olivekl commented Aug 7, 2023

Thank you, @hayleycd , for getting this PR to work, and @jonvnadelberg for all the work it reflects! @ltagliaferri @haydentherapper @smythp

@@ -1,8 +1,8 @@
---
title: "Contributing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was previously about contributing to docs, not contributing to Sigstore in general. Can we move the newly added content to the top of this file, and have subsections for specific projects, docs being the only one for now (we can add ones for fulcio, cosign, rekor, etc later on)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivekl what do you think about how to organize this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So one Contributing page that has info on how to contribute to Sigstore in general, contribute to docs specifically, as well as small sections on each subproject (which I imagine would link out to each repo's docs on GitHub)? That makes sense to me. I think having everything together is a good idea, even if some of the sections link out for more info.

Copy link
Collaborator

@jonvnadelberg jonvnadelberg Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll edit the "Contributing" section and add various subsections to it.

@@ -1,7 +1,7 @@
---
title: "Installation"
category: "Cosign"
position: 102
category: "System configuration"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the System Configuration section should be higher up, because installation is the first step. I would recommend it's after "About Sigstore" and before "Signing"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were thinking that you'd only install and configure once, but I can move it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option could be a link in the first page of Signing that says "as a prereq, install cosign" and link to later documentation?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option could be a link in the first page of Signing that says "as a prereq, install cosign" and link to later documentation?

The Getting Started page already says this:

Getting Started (Quick Start)
Cosign is a command line utility that can sign and verify software artifact, such as container images and blobs. Join us on our Slack channel. (Need an invite?)

Installation
To sign software artifacts and verify signatures using Sigstore, you need to install Cosign. Instructions to install Cosign can be found on the Cosign Installation page. This will allow you to sign and verify both blobs and containers.

Is that acceptable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that looks sufficient.

I'd recommend that Policy Controller and this section be moved above Certificate Authority and Transparency Log, given the latter two are for developers only.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -0,0 +1,7 @@
---
title: "Certificate transparency log information"
category: "Transparency Log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under Certificate Authority, not Transparency Log

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will move

position: 810
---

Review Rekor's [transparency log information](https://github.com/sigstore/fulcio/blob/main/docs/ctlog.md) on GitHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "Fulcio", not Rekor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

* [Rekor repository](https://github.com/sigstore/rekor)
* [Gitsign repository](https://github.com/sigstore/gitsign)
* [Policy Controller repository](https://github.com/sigstore/policy-controller)
* [Sigstore YouTube Channel](https://www.youtube.com/@projectsigstore)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this youtube link to a section on Get Help or learning more?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

* [Gitsign repository](https://github.com/sigstore/gitsign)
* [Policy Controller repository](https://github.com/sigstore/policy-controller)
* [Sigstore YouTube Channel](https://www.youtube.com/@projectsigstore)
* [Sigstore Blog](https://blog.sigstore.dev/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure the blog is linked somewhere? Maybe multiple places? Contributing, FAQ, Get Help, etc?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to just have it once, but I can put it in a few places if that's considered important.

@jonvnadelberg
Copy link
Collaborator

Thank you, @hayleycd , for getting this PR to work, and @jonvnadelberg for all the work it reflects! @ltagliaferri @haydentherapper @smythp

Thanks for the review, Hayden, I'm glad that nearly all of it is acceptable (I expected some change requests!). What we would like to do is install the changes as I have created them so far, and then quickly update with the requested changes. @ltagliaferri , can you go ahead and merge these changes in, and then we'll make the requested changes with additional PRs.

@smythp
Copy link
Collaborator

smythp commented Aug 10, 2023

Hey @jonvnadelberg, @olivekl, @haydentherapper,

Thanks for this PR, it represents a tremendous effort. This kind of organization is a real challenge on a docs site with so many moving pieces, and I think this will make the project more approachable for those coming to it for the first time.

I'm going to give some feedback here, but agree it might be best to merge this and tackle issues afterward. Apologies for providing feedback so late in the process.

I really like the tooling page. It may make sense to link it early in the overview. We don't actually come right out and say what Sigstore is on that page (i.e., that it's a suite of tools), and we could add a line on that and link to Tooling.

In the sidebar, Certficate Issuing > Certificate Issuing

I think following this update there is a good opportunity to do more with the "How to Use Sigstore" links on the overview page. Right now, the initial quickstart goes to the Cosign page, and I think the more task-based approach piloted here would also work well there.

This has been discussed, but we may want to revisit where the threat model page fits in, as it takes a somewhat different tone from the other intro pages. Similarly , it feels like the former"help" topics, like "contributing," might be placed under another heading. (Just something to consider later.)

Really like the new section headings ("signing,," etc.) It seems that the "overview" pages under these headings might be a good place to socialize the names of the tools for those new to the project. For example, instead of the first page under "Signing" being named "Overview," it could be called "Cosign Overview." (The page is already titled Cosign, so it also makes semantic sense.) On the other hand, perhaps you have a larger vision involving a content overhaul, in which case this might not fit into that.

I'll make issues for these questions. I say full steam ahead. Thanks again for the major effort on this reorganization initiative!

Signed-off-by: ltagliaferri <lisa.tagliaferri@gmail.com>
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand we want to merge in this change and then iterate on it. Since there was a typo in the sidebar I took a first pass on title casing all the titles there to be consistent (most were already title case)

I need another plus one to merge.

Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Great changes!

@haydentherapper
Copy link
Contributor

cc @bobcallaway for approval (there's no one else with push/merge permissions on the repo currently in the community repo)

@ltagliaferri ltagliaferri merged commit ebe8d31 into sigstore:main Aug 11, 2023
5 checks passed
@jonvnadelberg
Copy link
Collaborator

Hi @smythp I just created PR #235 does this cover what you would like to see?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants