Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite update page fix for #211, #210 #235

Closed
wants to merge 18 commits into from

Conversation

jonvnadelberg
Copy link
Collaborator

@jonvnadelberg jonvnadelberg commented Aug 23, 2023

Summary

Need to clarify the overview page to make it simpler and more complete than it was previously.

Release Note

NONE

Documentation

Fix for #210 #211 doc only

start of overview rewrite.

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
typos and removed redundant text.

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit 44e4229
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/64ececb353be210007d56591
😎 Deploy Preview https://deploy-preview-235--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonvnadelberg
Copy link
Collaborator Author

I rewrote the overview page. Please review @olivekl, @smythp. Does this correct issues with overview or does it need more work?

@jonvnadelberg jonvnadelberg changed the title rewrite update page fix for #211 rewrite update page fix for #211, #210 Aug 23, 2023
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@olivekl olivekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are GREAT changes. Thank you!!

content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@smythp smythp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think this does flesh things out and give a more complete intro.

I still think we could be higher-level in the very first paragraph (or two paragraphs). Something along these lines:

Sigstore is an open-source project for improving software supply chain security. The initiative provides a framework for signing and verifying software artifacts and for recording software supply chain metadata to an immutable ledger. Sigstore also maintains a suite of clients, APIs, and roots of trust, enabling developers to demonstrate and verify the provenance of software artifacts.

I guess when I look at a FOSS project, I want to know what kind of artifact it is (i.e., framework, client-side software, server-side software, specification, prototype, etc.) before reading about benefits and background, as it's essential context. I know we do a bunch of things here and it's consortial, which makes things more complicated, but functionally it's a FOSS project that provides roots of trust (like certs), a framework for signing and verifying stuff (artifacts is a good word as this is broad), and maintaining specific clients (like Cosign) and APIs (like the Rekor API).

One more suggestion (feel free to ignore) is that I do think it's helpful to have the quickstart links be pretty high up in the page, as they're really useful for a dev in a hurry. (That is, all devs.)

content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
content/en/docs/about/overview.md Outdated Show resolved Hide resolved
jonvnadelberg and others added 2 commits August 24, 2023 10:44
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Co-authored-by: olivekl <83081275+olivekl@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
@olivekl
Copy link
Contributor

olivekl commented Aug 24, 2023

Thanks for this, I think this does flesh things out and give a more complete intro.

I still think we could be higher-level in the very first paragraph (or two paragraphs). Something along these lines:

Sigstore is an open-source project for improving software supply chain security. The initiative provides a framework for signing and verifying software artifacts and for recording software supply chain metadata to an immutable ledger. Sigstore also maintains a suite of clients, APIs, and roots of trust, enabling developers to demonstrate and verify the provenance of software artifacts.

I agree in part: "Sigstore empowers developers..." (the current version) doesn't say what Sigstore is, so it'd be good to answer that more clearly in the opening sentence. I think the current version is clearer about what it actually does, though, in terms of what you can sign and how it's differs (no need to manage keys). "Immutable ledger" and "verify the provenance" are terms that are too technical to have in the opening paragraph, in my opinion.

Would you be open to a mashup?
Sigstore is an open source project for improving software supply chain security. The Sigstore framework and tooling empowers software developers and consumers to securely sign and verify software artifacts such as release files, container images, binaries, software bills of materials (SBOMs), and more. The signing materials are stored in a tamper-resistant public log so there’s no need to manage or store keys.

(Side note: we're not hyphenating open source even when used as a compound adjective (nor supply chain). It reduces confusion about when to use it vs not and doesn't lose an precision since both phrases are easily understood without the hyphen. The open source community seems to be moving in this direction grammatically.)

jonvnadelberg and others added 7 commits August 24, 2023 10:57
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
finish requests

Signed-off-by: jonvnadelberg <121979961+jonvnadelberg@users.noreply.github.com>
@smythp
Copy link
Collaborator

smythp commented Aug 24, 2023

That sounds good to me. My only real concern is getting in there that it's a project that offers a framework and maintains specific things, and mentioning what those things are, and that seems to do it. Agreed that we do cover what we do well, it's just not initially clear whether Sigstore is a protocol, server-side software, framework, etc., and we should cover that early on.

Think the adjectival open source versus open-source makes sense. I remember having these discussions with neologisms like ebook versus e-book back in the day, and the simpler version typically does and should win out.

Thank you, I know it's kind of annoying to write these intros by committee.

 Trying to sync
Signed-off by: Author Name <nadelberg@google.com>
@jonvnadelberg jonvnadelberg mentioned this pull request Aug 28, 2023
@jonvnadelberg jonvnadelberg deleted the update-overview branch September 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants