Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search bar and results more accessible #255

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Make search bar and results more accessible #255

merged 5 commits into from
Oct 16, 2023

Commits on Sep 26, 2023

  1. Make search bar and results more accessible 

    Added information on how to navigate to results in the aria-label
attribute on the search bar

Added a new field to English internationalization with instructions on
how to navigate to search results. This field will appear via the
aria-label to screen reader users.

Added an enclosing div informing screen readers to update when the
search results populate.

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
    @smythp
    smythp committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    34410eb View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Shortened aria-label for search, added search role 

    Made label instructing how to access search results less verbose

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
    @smythp
    smythp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0362aa3 View commit details
    Browse the repository at this point in the history

  2. Moved search role to form 

    Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
    @smythp
    smythp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    a03241b View commit details
    Browse the repository at this point in the history

  3. Changed aria label to include the word search 

    After testing, we found it better to include the word search.

Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
    @smythp
    smythp committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0c4070f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Changed aria-live from polite to assertive 

    Signed-off-by: Patrick Smyth <patrick@iotaschool.com>
    @smythp
    smythp committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4ee2c27 View commit details
    Browse the repository at this point in the history