Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search bar and results more accessible #255

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Make search bar and results more accessible #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34410eb
Make search bar and results more accessible
smythp Sep 26, 2023
0362aa3
Shortened aria-label for search, added search role
smythp Sep 27, 2023
a03241b
Moved search role to form
smythp Sep 27, 2023
0c4070f
Changed aria label to include the word search
smythp Sep 27, 2023
4ee2c27
Changed aria-live from polite to assertive
smythp Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions i18n/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- id: search-text
translation: "Search"

- id: search-aria-label
translation: "Search. Press tab to navigate to search results"

- id: 404-title
translation: "404 — Page not found."

Expand Down
7 changes: 5 additions & 2 deletions layouts/partials/header/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,13 @@ <h2 class="h5 offcanvas-title ps-2" id="offcanvasDoksLabel"><a class="text-dark"

{{ if $showFlexSearch -}}
<hr class="text-black-50 my-4 d-lg-none">
<form class="doks-search position-relative flex-grow-1 ms-lg-auto me-lg-2">
<input id="search" class="form-control is-search" type="search" placeholder="{{ i18n "search-text" }}" aria-label="{{ i18n "search-text" }}" autocomplete="off">

<div role="region" aria-live="assertive">
<form class="doks-search position-relative flex-grow-1 ms-lg-auto me-lg-2">
<input id="search" class="form-control is-search" type="search" placeholder="{{ i18n "search-text" }}" aria-label="{{ i18n "search-aria-label" }}" autocomplete="off">
<div id="suggestions" class="shadow bg-white rounded d-none"></div>
</form>
</div>
{{ end -}}

<hr class="text-black-50 my-4 d-lg-none">
Expand Down