-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] sky launch --fast #4159
Merged
Merged
[UX] sky launch --fast #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cg505
force-pushed
the
launch-skip-provisioning
branch
from
October 24, 2024 03:04
0ddcc4d
to
51c98d3
Compare
3 tasks
cg505
changed the title
[UX] skip provisioning stages if cluster is already available
[UX] sky launch --fast
Oct 26, 2024
5 tasks
…-skip-provisioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cg505!
romilbhardwaj
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--fast
flag tosky launch
.When in "fast" mode: check to see if the cluster name already exists, and if it does, and it's available, only run the stages used in
exec
(SYNC_WORKDIR and EXEC).Future PRs will catch cases where we should run more stages, such as if the cluster is outdated, and add documentation.
Tested (run the relevant ones):
bash format.sh
test_launch_fast
andtest_launch_fast_with_autostop
.pytest tests/test_smoke.py
on AWS and Azureconda deactivate; bash -i tests/backward_compatibility_tests.sh