Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] sky launch --fast #4159

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

cg505
Copy link
Collaborator

@cg505 cg505 commented Oct 24, 2024

Add a --fast flag to sky launch.
When in "fast" mode: check to see if the cluster name already exists, and if it does, and it's available, only run the stages used in exec (SYNC_WORKDIR and EXEC).

Future PRs will catch cases where we should run more stages, such as if the cluster is outdated, and add documentation.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • Manually tested happy path
    • Manually tested on an autostopped or autodowned cluster.
  • New smoke tests test_launch_fast and test_launch_fast_with_autostop.
  • All smoke tests: pytest tests/test_smoke.py on AWS and Azure
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cg505 cg505 changed the title [UX] skip provisioning stages if cluster is already available [UX] sky launch --fast Oct 26, 2024
@cg505 cg505 marked this pull request as ready for review October 26, 2024 02:02
@cg505 cg505 requested a review from Michaelvll October 28, 2024 21:01
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cg505!

sky/cli.py Outdated Show resolved Hide resolved
sky/execution.py Outdated Show resolved Hide resolved
sky/cli.py Outdated Show resolved Hide resolved
sky/execution.py Outdated Show resolved Hide resolved
sky/execution.py Outdated Show resolved Hide resolved
@cg505 cg505 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into skypilot-org:master with commit 22fd238 Oct 31, 2024
20 checks passed
@cg505 cg505 deleted the launch-skip-provisioning branch October 31, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants