Low-hanging perf improvements in highlighting code #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 462eaf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stellarhoof
force-pushed
the
feature/highlighting-perf-improvements
branch
from
3554846
to
21436b6
Compare
stellarhoof
force-pushed
the
feature/highlighting-perf-improvements
branch
from
21436b6
to
1237b3a
Compare
dubiousdavid
reviewed
Feb 5, 2024
dubiousdavid
reviewed
Feb 6, 2024
| (acc, field, path) => { | ||
| let subFields = getFieldSubFields(field) | ||
| for (let k in subFields) acc[`${path}.${k}`] = subFields[k] | ||
| return acc |
There was a problem hiding this comment.
Mutating the accumulator and then returning it feels kind of silly to me. Why not just use a for loop. It's easy to read and clearly indicates the imperative approach you're taking here.
dubiousdavid
reviewed
Feb 6, 2024
| @@ -6,7 +6,7 @@ import { groupStats } from './groupStatUtils.js' | |||
| // [1, 2, 3] -> [{to: 1}, {from: 1, to: 2}, {from: 2, to: 3}, {from: 3}] | |||
| let boundariesToRanges = _.flow( | |||
| F.mapIndexed((to, i, list) => F.compactObject({ from: list[i - 1], to })), | |||
| (arr) => F.push({ from: _.last(arr).to }, arr) | |||
| (arr) => F.pushOn(arr, { from: _.last(arr).to }) | |||
There was a problem hiding this comment.
I think I actually prefer F.push here. Mixing non-mutating with mutating in the same flow is kind of awkward for me. If you want to mutate an array with push you should just loop over the array and do that.
dubiousdavid
reviewed
Feb 6, 2024
| @@ -148,7 +151,7 @@ export let getAllHighlightFields = _.memoize((schema) => { | |||
| let collectKeysAndValues = (f, coll) => | |||
| F.reduceTree()( | |||
| (acc, val, key) => | |||
| f(val) ? F.push(val, acc) : f(key) ? F.push(key, acc) : acc, | |||
| f(val) ? F.pushOn(acc, val) : f(key) ? F.pushOn(acc, key) : acc, | |||
There was a problem hiding this comment.
Same kind of thing here. Using reduce with a mutating call in the reducing function feels a little awkward to me. Why not just walk the tree and and push onto an array?
stellarhoof
force-pushed
the
feature/highlighting-perf-improvements
branch
from
1d609cc
to
462eaf0
Compare
|
Coverage after merging feature/highlighting-perf-improvements into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dubiousdavid
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
F.pushOnin more places and a few perf tweaks in hot code paths.