Low-hanging perf improvements in highlighting code

.changeset/purple-ghosts-heal.md

@@ -0,0 +1,5 @@
+---
+'contexture-elasticsearch': patch
+---
+
+Low-hanging perf improvements in elasticsearch highlighting

packages/provider-elasticsearch/src/example-types/metricGroups/percentilesGroupStats.js

@@ -4,10 +4,13 @@ import { pickSafeNumbers } from '../../utils/futil.js'
 import { groupStats } from './groupStatUtils.js'
 
 // [1, 2, 3] -> [{to: 1}, {from: 1, to: 2}, {from: 2, to: 3}, {from: 3}]
-let boundariesToRanges = _.flow(
-  F.mapIndexed((to, i, list) => F.compactObject({ from: list[i - 1], to })),
-  (arr) => F.push({ from: _.last(arr).to }, arr)
-)
+let boundariesToRanges = (boundaries) => {
+  let ranges = F.mapIndexed(
+    (to, i, list) => F.compactObject({ from: list[i - 1], to }),
+    boundaries
+  )
+  return [...ranges, { from: _.last(ranges)?.to }]
+}
 
 let drilldownToRange = (drilldown) => {
   let [gte, lt] = _.split('-', drilldown)

packages/provider-elasticsearch/src/example-types/results/highlighting/request.js

@@ -95,16 +95,16 @@ let getFieldSubFields = (field) =>
 /**
  * Returns object of all subfields in a schema.
  */
-let getSchemaSubFields = (schema) =>
-  F.reduceIndexed(
-    (acc, field, path) =>
-      F.mergeOn(
-        acc,
-        _.mapKeys((k) => `${path}.${k}`, getFieldSubFields(field))
-      ),
-    {},
-    schema.fields
-  )
+let getSchemaSubFields = _.memoize((schema) => {
+  let acc = {}
+  for (let path in schema.fields) {
+    let subFields = getFieldSubFields(schema.fields[path])
+    for (let k in subFields) {
+      acc[`${path}.${k}`] = subFields[k]
+    }
+  }
+  return acc
+}, _.get('elasticsearch.index'))
 
 /**
  * Returns object of all group fields and their subfields in a schema.
@@ -145,13 +145,14 @@ export let getAllHighlightFields = _.memoize((schema) => {
   })
 }, _.get('elasticsearch.index'))
 
-let collectKeysAndValues = (f, coll) =>
-  F.reduceTree()(
-    (acc, val, key) =>
-      f(val) ? F.push(val, acc) : f(key) ? F.push(key, acc) : acc,
-    [],
-    coll
-  )
+let collectKeysAndValues = (predicate, coll) => {
+  let acc = []
+  F.walk()((val, key) => {
+    if (predicate(val)) acc.push(val)
+    else if (predicate(key)) acc.push(key)
+  })(coll)
+  return acc
+}
 
 let blobConfiguration = {
   fragment_size: 250,