Add a backend for waitable handles #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, the concept looks good overall, but I wasn't yet able to look through in detail. |
|
I realized that |
This should be fixed as of now. |
Signed-off-by: John Nunley <dev@notgull.net>
This commit adds a new backend for the process reaper. Rather than waiting on a signal, it instead registers the process's pidfd into async-io and waits on that instead. I've coded this backend to also allow for other systems to be registered here as well. Signed-off-by: John Nunley <dev@notgull.net>
|
@smol-rs/admins Any chance this PR can be reviewed? |
fogti
reviewed
Mar 25, 2024
fogti
reviewed
Mar 25, 2024
fogti
reviewed
Mar 28, 2024
fogti
reviewed
Mar 28, 2024
fogti
reviewed
Mar 28, 2024
fogti
approved these changes
Mar 28, 2024
As pidfd isn't available in older versions of Linux that Rust still supports, this is necessary for running on older Linux. In addition, signals tests are still kept in CI. Signed-off-by: John Nunley <dev@notgull.net>
Merged
fogti
reviewed
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new backend for the process reaper. Rather than
waiting on a signal, it instead registers the process's pidfd into
async-io and waits on that instead.
I've coded this backend to also allow for other systems to be registered
here as well.
cc #49