Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derives to cairo-lang-macro #1676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add derives to cairo-lang-macro #1676

wants to merge 1 commit into from
+7 −6

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Oct 24, 2024 •
edited
Loading

This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@maciektr
Copy link
Contributor

Can we hide it behind a feature (both dependency declaration and usages) to retain minimal set of deps for building macros on user side?

mkaput
mkaput requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking because of #1676 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput requested changes

@maciektr maciektr Awaiting requested review from maciektr maciektr is a code owner

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG DelevoXDG is a code owner

@wawel37 wawel37 Awaiting requested review from wawel37 wawel37 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draggu @maciektr @mkaput