Add request handling #1682
Open
Add request handling #1682
+42
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit-id:723491f5
This was referenced Oct 24, 2024
mkaput
requested changes
Oct 25, 2024
|
|
||
| pub fn start_proc_macro_server(proc_macros: ProcMacroHost) -> Result<()> { | ||
| let connection = Connection::new(); | ||
|
|
||
| //TODO | ||
| for i in 0..4 { |
There was a problem hiding this comment.
use std::thread:available_parallelism. do not hardcode threading amounts
| use serde::Serialize; | ||
|
|
||
| #[derive(Serialize)] | ||
| pub struct ErrResponse { |
There was a problem hiding this comment.
this should probably reside in proc-macros-server-api crate. I made a related comment about this in that PR: #1678 (comment)
There was a problem hiding this comment.
please start adding tests for this system starting with this PR
mkaput
requested changes
Oct 25, 2024
| .name(format!("proc-macro-server-worker-thread-{i}")) | ||
| .spawn(move || { | ||
| for request in receiver { | ||
| let response = match request.method.as_str() { |
There was a problem hiding this comment.
the indentation is going crazy here, please:
- extract worker body to a separate function
- extract request method routing to another one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
ExpandInlinehandler #1686ExpandDerivehandler #1685ExpandAttributehandler #1684DefinedMacroshandler #1683ProcMacroHost#1680proc-macro-servercommand #1679cairo-lang-macrofix null-byte panics #1677cairo-lang-macro#1676