Conditional Region Support #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we run that again? @phschaad |
tbennun
approved these changes
Oct 31, 2024
tsconfig.json
Outdated
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "module": "commonjs", | |||
| "target": "ES2022", | |||
| "target": "ESNext", | |||
There was a problem hiding this comment.
oh dear why. Which feature necessitates this and is there good support in Electron?
There was a problem hiding this comment.
Very good catch, I don't recall why I modified this. I have reverted it to ES2022, which is also what the webclient now depends on following this PR: spcl/dace-webclient#181
Note that we would in theory be fine with ESNext, as VSCode's version of Electron uses a version of the V8 engine which supports quite a few features that are not even in the most recent ECMA standard yet, but this is definitely the safer option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the extension works with Conditoinal regions and Loop regions, to the extent they will be present / used in DaCe 1.0.
Relies on spcl/dace-webclient#180.