Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out overlay type #180

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Refactor out overlay type #180

merged 1 commit into from
Oct 31, 2024

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Oct 31, 2024 •
edited
Loading

Companion to spcl/dace-vscode#268

@phschaad phschaad requested a review from tbennun October 31, 2024 11:02
@phschaad phschaad mentioned this pull request Oct 31, 2024
Merged
tbennun
tbennun approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked like it was going to reduce the code redundancy but that's not what it was, still LGTM!

@phschaad
Copy link
Collaborator Author

Sadly not yet, but that is still firmly planned soon as well - only restriction is available time.. :-)

@phschaad phschaad merged commit 4d0dc29 into main Oct 31, 2024
4 checks passed
@phschaad phschaad deleted the users/phschaad/type_refactor branch October 31, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phschaad @tbennun