Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dont error out on version parse if we fail, just skip dealing w/ license secret #40

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

carlmontanari
Copy link
Contributor

title! some folks are wanting to use arbitrary tags and currently this results in us returning an error from the image/tag parsing which prevents us from getting a pod deployed. this pr simply returns an empty version object rather than an error if we can't parse things. worst case folks will have no secret.

holler if this needs tweaking and ill get whatever sorted!

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1844b46) 50.93% compared to head (1cd1e85) 50.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   50.93%   50.87%   -0.07%     
==========================================
  Files           8        8              
  Lines         799      804       +5     
==========================================
+ Hits          407      409       +2     
- Misses        365      369       +4     
+ Partials       27       26       -1     
Files Coverage Δ
api/v1/srl_version.go 100.00% <100.00%> (ø)
api/v1/srlinux_types.go 100.00% <100.00%> (ø)
controllers/secret.go 41.23% <88.88%> (-0.07%) ⬇️

@hellt
Copy link
Member

hellt commented Feb 2, 2024

LGTM, @carlmontanari
Feel free to merge this one

@carlmontanari carlmontanari marked this pull request as ready for review February 2, 2024 20:33
@carlmontanari carlmontanari merged commit fad8b54 into main Feb 2, 2024
5 of 6 checks passed
@carlmontanari carlmontanari deleted the feat/ignore-license-if-version-parse-fails branch February 2, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants